Bump Microsoft.CodeAnalysis.CSharp from 4.2.0 to 4.3.0

[dependabot]

Bumps Microsoft.CodeAnalysis.CSharp from 4.2.0 to 4.3.0.

Release notes

Sourced from Microsoft.CodeAnalysis.CSharp's releases.

.NET 6.0.1

Release

.NET 5.0.4

Release

.NET 5.0.2

Release Notes Install Instructions

Repos

• Core

Changelog

Sourced from Microsoft.CodeAnalysis.CSharp's changelog.

API Breaking Changes

Version 1.1.0

Removed VisualBasicCommandLineParser.ctor

During a toolset update we noticed the constructor on VisualBasicCommandLineParser was public. This in turn made many of the protected members of CommandLineParser a part of the API surface as it gave external customers an inheritance path.

It was never the intent for these members to be a part of the supported API surface. Creation of the parsers is meant to be done via the Default singleton properties. There seems to be little risk that we broke any customers here and hence we decided to remove this API.

PR: dotnet/roslyn#4169

Changed Simplifier methods to throw ArgumentNullExceptions

Changed Simplifier.ReduceAsync, Simplifier.ExpandAsync, and Simplifier.Expand methods to throw ArgumentNullExceptions if any non-optional, nullable arguments are passed in. Previously the user would get a NullReferenceException for synchronous methods and an AggregateException containing a NullReferenceException for asynchronous methods.

PR: dotnet/roslyn#5144

Version 1.3.0

Treat a method marked with both public and private flags as private

The scenario is loading an assembly where some methods, fields or nested types have accessibility flags set to 7 (all three bits set), which mean public AND private. After the fix, such flags are loaded to mean private. The compat change is we’re trading a compile-time success and runtime failure (native compiler) against a compile-time error (restoring the behavior of v1.2).

Details below:

• The native compiler successfully compiles the method and field case (those only yield runtime error System.TypeLoadException: Invalid Field Access Flags) and reported an accessibility error on the nested type.
• The 1.2 compiler generated errors:

error BC30390: 'C.Private Overloads Sub M()' is not accessible in this context because it is 'Private'.
error BC30389: 'C.F' is not accessible in this context because it is 'Private'.
error BC30389: 'C.C2' is not accessible in this context because it is 'Protected Friend'.
error BC30390: 'C2.Private Overloads Sub M2()' is not accessible in this context because it is 'Private'.

• The 1.3 compiler crashes.
• After fix, the same errors as 1.2 are generated again.

PR: dotnet/roslyn#11547

Don't emit bad DateTimeConstant, and load bad BadTimeConstant as default value instead

The change affects compatibility in two ways:

• When loading an invalid DateTimeConstant(-1), the compiler will use default(DateTime) instead, whereas the native compiler would produce code that fails to execute.
• DateTimeConstant(-1) will still count when we check that you don’t specify two default values. The compiler will produce an error, instead of succeeding (and producing IL with two attributes).

PR: dotnet/roslyn#11536

Version 4.1.0

... (truncated)

Commits

• 88ca01f Merge pull request #33940 from v-mdriml/localization
• f68445e LOC CHECKIN | dotnet/roslyn dev16.0-vs-deps | 20190312 fix
• 1a1120c Merge pull request #34023 from dotnet/merges/dev16.0-to-dev16.0-vs-deps
• aaa7451 Merge pull request #33902 from genlu/fix33890
• d57da97 Merge pull request #33990 from dotnet/merges/dev16.0-to-dev16.0-vs-deps
• 90ce253 Update to Arcade 1.0.0-beta.19157.23 (#33974)
• c03b883 Fix type
• 68db1a0 Merge pull request #33827 from sharwell/caret-visible
• 516a25d Merge pull request #33828 from sharwell/line-ender
• b6c6008 Merge pull request #33830 from sharwell/readonly-completion
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[rmarinho]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).