Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CalendarDatePickerExtensions.ToDateFormat internal until .NET 7 #8930

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Make CalendarDatePickerExtensions.ToDateFormat internal until .NET 7 #8930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
104603e
Internalize added APIs
jfversluis Jul 22, 2022
047b423
Update CalendarDatePickerExtensions.cs
rmarinho Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Core/src/Platform/Windows/CalendarDatePickerExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@

namespace Microsoft.Maui.Platform
{
public static class CalendarDatePickerExtensions
//TODO make this public on NET7
internal static class CalendarDatePickerExtensions
{
public static string ToDateFormat(this string dateFormat)
internal static string ToDateFormat(this string dateFormat)
{
// The WinUI CalendarDatePicker DateFormat property use this formatter:
// https://docs.microsoft.com/en-us/uwp/api/Windows.Globalization.DateTimeFormatting.DateTimeFormatter?redirectedfrom=MSDN&view=winrt-22621#code-snippet-2
Expand Down Expand Up @@ -156,4 +157,4 @@ internal static bool CheckDateFormat(string format)
return string.IsNullOrWhiteSpace(format) || format.Equals("d", StringComparison.Ordinal);
}
}
}
}
2 changes: 0 additions & 2 deletions src/Core/src/PublicAPI/net-windows/PublicAPI.Unshipped.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#nullable enable
override Microsoft.Maui.Handlers.EditorHandler.SetVirtualView(Microsoft.Maui.IView! view) -> void
override Microsoft.Maui.Handlers.EntryHandler.SetVirtualView(Microsoft.Maui.IView! view) -> void
Microsoft.Maui.Platform.CalendarDatePickerExtensions
static Microsoft.Maui.Platform.CalendarDatePickerExtensions.ToDateFormat(this string! dateFormat) -> string!