-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net7] include net6 templates #8203
Conversation
Make this the released nuget package version as defined in version.props by a new variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you dotnet new maui
, how does it decide which template to use?
There's the new parameter for the sdk version, I think you can specify that in the CLI if you want to override the default which I believe is based on the dotnet sdk in the context you are running the command from. |
Should we test the new switch here: Lines 145 to 147 in a1a9a44
Basically test all the templates twice, once for 6 and once for 7. |
Yeah, we can duplicate the stage with different parameters. |
This PR with make it possible to run things for net6 and net7: #8237 I finally got the quotes to work, so once that is merged, I'll update this PR. |
|
According to physics, that should be there for net7. According to CI it is not. |
For another PR later: We can do amazing things with the actual target platforms and make the csproj beautiful-er |
src/Workload/Microsoft.NET.Sdk.Maui/WorkloadManifest.in.targets
Outdated
Show resolved
Hide resolved
eng/Versions.props
Outdated
<!-- Current previous .NET SDK major version's stable release of MAUI packages --> | ||
<MicrosoftMauiPreviousDotNetReleasedVersion>6.0.500-preview.1.6049</MicrosoftMauiPreviousDotNetReleasedVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be replaced with the shipping version of MAUI SR2
Description of Change
Since you can still build a net6.0-* MAUI app with the net7 SDK, we also want to ship the net6 template packs as part of the workload.
This adds the previous dotnet sdk template pack to the manifest.
Support
Linker produces colliding MVID for two different inputs linker#2203
Deterministic MVIDs is needed for assemblies referencing System.Private.CoreLib across different architectures runtime#67660