Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip invalidation on propagation (#25652) #25696

Merged
merged 7 commits into from
Nov 6, 2024

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Nov 5, 2024

Description of Change

Backporting #25652

* Skip Invalidation unless you're my immediate child

* - fix override on test

* Fix Legacy Layouts Invalidation Propagation

* - use invalidation args to propagate depth
# Conflicts:
#	src/Controls/src/Core/Page/Page.cs
#	src/Controls/src/Core/VisualElement/VisualElement.cs
@PureWeen PureWeen requested a review from a team as a code owner November 5, 2024 17:55
@PureWeen PureWeen requested review from Eilon and tj-devel709 and removed request for a team November 5, 2024 17:55
@PureWeen PureWeen added this to the .NET 8 SR10 milestone Nov 5, 2024
@PureWeen PureWeen merged commit e29ebff into release/8.0.1xx-sr10 Nov 6, 2024
6 of 7 checks passed
@PureWeen PureWeen deleted the backport_25652_to_sr10 branch November 6, 2024 15:34
InvalidateMeasureLegacy(trigger, depth, int.MaxValue);
}

// This lets us override the rules for invalidation on MAUI controls that unfortunately still inheirt from the legacy layout
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inherit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants