Fix toggle for including sample content in template #25549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
t/bug
Redth
reviewed
Oct 28, 2024
src/Templates/src/templates/maui-mobile/.template.config/dotnetcli.host.json
Outdated
Show resolved
Hide resolved
|
/azp run |
Redth
previously approved these changes
Oct 28, 2024
|
/backport to release/9.0.1xx |
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/maui/actions/runs/11564984035 |
Redth
added a commit
that referenced
this pull request
Oct 29, 2024
…#25564) Backport of #25549 to release/9.0.1xx /cc @Redth @jfversluis
|
Will this be available in VS before the GA release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This fixes the toggle for including sample content in the template. In #25419 some last-minute changes were made to not make the sample content show up by default, but that introduced a bug where you couldn't get the sample content to show up at all using Visual Studio.
With this change the sample content can optionally be included again in Visual Studio by using the checkbox and through the CLI by specifying either
--sample-contentor-sc.Also the not used
Emptyswitch was removed as well as theSampleContentvariable which did not serve any additional purpose.