Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[testing] Comment out flaky test #25188

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[testing] Comment out flaky test #25188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions src/Controls/tests/Core.UnitTests/ShellModalTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,34 +404,34 @@ public async Task PoppingWithQueryString(string input)
Assert.Equal("1234", testPage.SomeQueryParameter);
}

[Fact]
public async Task NavigatingAndNavigatedFiresForShellModal()
{
Shell shell = new TestShell();
shell.Items.Add(CreateShellItem(shellItemRoute: "NewRoute", shellSectionRoute: "Section", shellContentRoute: "Content"));
// [Fact]
// public async Task NavigatingAndNavigatedFiresForShellModal()
// {
// Shell shell = new TestShell();
// shell.Items.Add(CreateShellItem(shellItemRoute: "NewRoute", shellSectionRoute: "Section", shellContentRoute: "Content"));

ShellNavigatingEventArgs shellNavigatingEventArgs = null;
ShellNavigatedEventArgs shellNavigatedEventArgs = null;
// ShellNavigatingEventArgs shellNavigatingEventArgs = null;
// ShellNavigatedEventArgs shellNavigatedEventArgs = null;

shell.Navigating += (_, args) =>
{
shellNavigatingEventArgs = args;
};
// shell.Navigating += (_, args) =>
// {
// shellNavigatingEventArgs = args;
// };

shell.Navigated += (_, args) =>
{
shellNavigatedEventArgs = args;
};
// shell.Navigated += (_, args) =>
// {
// shellNavigatedEventArgs = args;
// };

await shell.GoToAsync("ModalTestPage");
// await shell.GoToAsync("ModalTestPage");

Assert.NotNull(shellNavigatingEventArgs);
Assert.NotNull(shellNavigatedEventArgs);
// Assert.NotNull(shellNavigatingEventArgs);
// Assert.NotNull(shellNavigatedEventArgs);

Assert.Equal("//NewRoute/Section/Content", shellNavigatingEventArgs.Current.FullLocation.ToString());
Assert.Equal("//NewRoute/Section/Content/ModalTestPage", shellNavigatedEventArgs.Current.FullLocation.ToString());
// Assert.Equal("//NewRoute/Section/Content", shellNavigatingEventArgs.Current.FullLocation.ToString());
// Assert.Equal("//NewRoute/Section/Content/ModalTestPage", shellNavigatedEventArgs.Current.FullLocation.ToString());

}
// }

[Fact]
public async Task GetCurrentPageInModalNavigation()
Expand Down
Loading