-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a rendering performance test #24762
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/RenderingPerformance.cs
Outdated
Show resolved
Hide resolved
albyrock87
force-pushed
the
adds-performance-test
branch
8 times, most recently
from
September 14, 2024 18:57
274481a
to
9d3e259
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
tj-devel709
added
area-testing
Unit tests, device tests
area-layout
StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter
labels
Sep 16, 2024
albyrock87
force-pushed
the
adds-performance-test
branch
from
September 18, 2024 19:25
9d3e259
to
202e8aa
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
jonathanpeppers
previously approved these changes
Sep 19, 2024
albyrock87
force-pushed
the
adds-performance-test
branch
4 times, most recently
from
September 20, 2024 09:40
a112d1b
to
a78be0b
Compare
albyrock87
force-pushed
the
adds-performance-test
branch
from
September 20, 2024 09:41
a78be0b
to
1f13dcd
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Sep 20, 2024
Do I understand correctly that once this is merged, then every time CI runs we'll have in Azure test's attachments a file with performance data? |
@MartyIX that's correct, except for the windows platform where for some reason it doesn't show up on ADO. |
redducks100
pushed a commit
to redducks100/maui
that referenced
this pull request
Sep 24, 2024
samhouts
added
fixed-in-net9.0-nightly
This may be available in a nightly release!
fixed-in-net8.0-nightly
This may be available in a nightly release!
labels
Oct 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-layout
StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter
area-testing
Unit tests, device tests
community ✨
Community Contribution
fixed-in-net8.0-nightly
This may be available in a nightly release!
fixed-in-net9.0-nightly
This may be available in a nightly release!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This introduces a UI test to measure rendering performance.
Measurement happens by tracking IView.Frame mapping which happens right after the platform has arranged the view in the container view.
First pass
First time we generate 40 * 10 + 1 = 401 items.
This causes the creation of (40 * 5) + (40 * 10 * 4) + (1 * 5) + (1 * 4) = ~1800 platform views.
Second pass
Second time we generate 20 * 10 + 1 = 201 items.
This causes (20 * 5) + (20 * 10 * 4) = ~900 binding context changes and other ~900 platform views removals.
Third pass
Third time we manually clear the BindableContainer and reset the models to the initial state (1 measured item)
Notes
This enables us to measure the time it takes to:
Views include frequently used components like
ContentView
(legacy layout),Border
,VerticalStackLayout
,Grid
,Label
.Output
Sample output visible in Azure test's attachments: