Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure disconnected ItemsViewHandler doesn't hold onto the items source #24699

Merged
merged 2 commits into from
Sep 11, 2024

Update CarouselViewTests.cs

f940bb5
Select commit
Loading
Failed to load commit list.
Merged

Ensure disconnected ItemsViewHandler doesn't hold onto the items source #24699

Update CarouselViewTests.cs
f940bb5
Select commit
Loading
Failed to load commit list.
Azure Pipelines / MAUI-UITests-public succeeded Sep 11, 2024 in 2h 33m 36s

Build #8.0.90-ci+pr.24699.azdo.123552 had test failures

Details

Tests

  • Failed: 2 (0.11%)
  • Passed: 1,189 (63.41%)
  • Other: 684 (36.48%)
  • Total: 1,875

Annotations

Check failure on line 738 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L738

PowerShell exited with code '1'.

Check failure on line 835 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L835

PowerShell exited with code '1'.

Check failure on line 601 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L601

PowerShell exited with code '1'.

Check failure on line 589 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Build log #L589

PowerShell exited with code '1'.

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.Issues.Issue22417(Windows).AddItemsToCarouselViewWorks

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.Issues.Issue22417(Windows).AddItemsToCarouselViewWorks

The app was expected to be running still, investigate as possible crash
TearDown : OpenQA.Selenium.WebDriverException : The HTTP request to the remote WebDriver server for URL http://localhost:4723/wd/hub/session/cb827ca9-2088-484a-85e6-584cee029c2c/source timed out after 60 seconds.
  ----> System.Threading.Tasks.TaskCanceledException : The request was canceled due to the configured HttpClient.Timeout of 60 seconds elapsing.
  ----> System.TimeoutException : The operation was canceled.
  ----> System.Threading.Tasks.TaskCanceledException : The operation was canceled.
  ----> System.Net.Http.HttpIOException : The response ended prematurely. (ResponseEnded)
Raw output
   at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 84
   at UITest.Appium.NUnit.UITestBase.TestTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 34

--TearDown
   at OpenQA.Selenium.Remote.HttpCommandExecutor.Execute(Command commandToExecute)
   at OpenQA.Selenium.Appium.Service.AppiumCommandExecutor.Execute(Command commandToExecute)
   at OpenQA.Selenium.WebDriver.Execute(String driverCommandToExecute, Dictionary`2 parameters)
   at OpenQA.Selenium.WebDriver.get_PageSource()
   at UITest.Appium.AppiumApp.get_ElementTree() in /_/src/TestUtils/src/UITest.Appium/AppiumApp.cs:line 38
   at UITest.Appium.NUnit.UITestBase.SaveUIDiagnosticInfo(String note) in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 179
   at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 94
   at UITest.Appium.NUnit.UITestBase.TestTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 34
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
--TaskCanceledException
   at System.Net.Http.HttpClient.HandleFailure(Exception e, Boolean telemetryStarted, HttpResponseMessage response, CancellationTokenSource cts, CancellationToken cancellationToken, CancellationTokenSource pendingRequestsCts)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at OpenQA.Selenium.Remote.HttpCommandExecutor.MakeHttpRequest(HttpRequestInfo requestInfo)
   at OpenQA.Selenium.Remote.HttpCommandExecutor.<>c__DisplayClass33_0.<<Execute>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at OpenQA.Selenium.Remote.HttpCommandExecutor.Execute(Command commandToExecute)
--TimeoutException

--TaskCanceledException
   at System.Net.Http.HttpConnection.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
--HttpIOException
   at System.Net.Http.HttpConnection.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
1)    at UITest.Appium.NUnit.UITestBase.UITestBaseTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 84
   at UITest.Appium.NUnit.UITestBase.TestTearDown() in /_/src/TestUtils/src/UITest.NUnit/UITestBase.cs:line 34

Check failure on line 1 in Microsoft.Maui.TestCases.Tests.Issues.Issue22417(Windows).AddItemsToCarouselViewWorks

See this annotation in the file changed.

@azure-pipelines azure-pipelines / MAUI-UITests-public

Microsoft.Maui.TestCases.Tests.Issues.Issue22417(Windows).AddItemsToCarouselViewWorks

VisualTestUtils.VisualTestFailedException : 
Snapshot different than baseline: AddItemsToCarouselViewWorks.png (20.50% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow
Raw output
   at VisualTestUtils.VisualRegressionTester.Fail(String message)
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext)
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|7_0(String name) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 217
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 105
   at Microsoft.Maui.TestCases.Tests.Issues.Issue22417.AddItemsToCarouselViewWorks() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22417.cs:line 24
   at NUnit.Framework.Internal.TaskAwaitAdapter.GenericAdapter`1.BlockUntilCompleted()
   at NUnit.Framework.Internal.MessagePumpStrategy.NoMessagePumpStrategy.WaitForCompletion(AwaitAdapter awaiter)
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await[TResult](Func`1 invoke)
   at NUnit.Framework.Internal.AsyncToSyncAdapter.Await(Func`1 invoke)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.RunTestMethod(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.TestMethodCommand.Execute(TestExecutionContext context)
   at NUnit.Framework.Internal.Commands.DelegatingTestCommand.RunTestMethodInThreadAbortSafeZone(TestExecutionContext context, Action action)