Trigger InvalidateMeasure event on CollectionView when content size changes (iOS) #24647
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| @@ -403,6 +409,13 @@ await CreateHandlerAndAddToWindow<LayoutHandler>(layout, async handler => | |||
| ? containerHeight | |||
| : Math.Min(itemsCount * templateHeight, containerHeight); | |||
|
|
|||
| #if IOS | |||
There was a problem hiding this comment.
Should this work on Windows and Android?
If it currently doesn't and should, would it make sense to open an issue?
There was a problem hiding this comment.
I'd say: it should work on all platforms.
But apparently it only makes an actual difference on iOS (issue author is only talking about such platform).
I can try to make it work on Android, but I'll need some help for the Windows platform.
There was a problem hiding this comment.
More just curious if we should log an issue
If this test currently fails for Android/Windows we can just log an issue saying so and link to it. No need to hold this PR up for Android/Windows.
There was a problem hiding this comment.
Sounds good, I'll file a new issue then.
(Test is failing there)
albyrock87
changed the title
Description of Change
Problem reported in #21141 has been fixed by #23052 , except for one use case: nested collection view.
The nested
CollectionViewshould triggerMeasureInvalidatedbut it's not: it is just triggeringSetNeedsLayouton the native view.This PR adds the event triggering so that the parent
TemplatedCellcan react to it.Issues Fixed
Fixes #21141