Fix layout when MinimumWidth/HeightRequest is removed on Windows #24639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ack, the test passed locally on Windows and Android. Maybe I need to request a smaller min width/height since the height ended up being 486 instead of 500. |
PureWeen
requested changes
Sep 7, 2024
PureWeen
approved these changes
Sep 8, 2024
samhouts
added
the
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
and removed
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
ViewExtensions.UpdateMinimumHeight|Widthfor WinUI is supposed to updateFrameworkElement.MinHeight|Widthbased on the MAUI propertyMinimumHeightRequest/MinimumWidthRequest. But it would completely skip the update when the value was removed, so the previously set value would stay in effect. That locks in the oldFrameworkElement.MinHeight|Width, and layout doesn't change.The fix is to remove
FrameworkElement.MinHeight|WidthwhenMinimumHeightRequest/MinimumWidthRequestis removed.Issues Fixed
Fixes #24638