Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump WinAppSDK to 1.6 #24266

Merged
merged 66 commits into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
9c8c2cb
Bump WinAppSDK version + WebView2 version
Aug 15, 2024
c30ee86
Add WebView2 ref to Controls.Core
Aug 15, 2024
b406e46
Add another package ref
Aug 15, 2024
f4b78e8
Merge branch 'net9.0' into foda/winappsdk16
Foda Aug 20, 2024
2614bf1
Bump SDK versions
Aug 21, 2024
e32e613
Bump winappsdk version
Aug 22, 2024
e2fc4dd
Merge branch 'net9.0' into foda/winappsdk16
Aug 22, 2024
800c9f3
Add missing package ref
Aug 22, 2024
021a85d
Update NuGet.config
mattleibow Aug 23, 2024
d783b46
Update Directory.Build.props
mattleibow Aug 23, 2024
47470c9
Use SDK v38
Aug 23, 2024
9c1b25d
Remove refs to WebView2, use `WindowsAppSDK`
Aug 23, 2024
80b334d
Add more package refs
Aug 27, 2024
21f360a
Use the correct way to check for a window style (see: OverlappedPrese…
Aug 29, 2024
2930d70
More pkgs for webview
Aug 29, 2024
dad501d
Mark test as unstable
Aug 30, 2024
47a7672
TEST: add monitor info for test context
Sep 3, 2024
4a4c24e
Revert change, try manually setting button height...?!
Sep 3, 2024
73e1703
Move style
Sep 3, 2024
90f19b4
Revert change
Sep 4, 2024
73dd204
Merge branch 'net9.0' into foda/winappsdk16
Foda Sep 4, 2024
f935087
Ensure more fonts are consistant
Sep 4, 2024
cd83a0d
Merge branch 'foda/winappsdk16' of https://github.com/dotnet/maui int…
Sep 4, 2024
9f4226b
Bump SDK version
Sep 5, 2024
402894f
Update images for tests
Sep 5, 2024
26af5cf
Update more images
Sep 6, 2024
fd29bdb
Huh
Sep 6, 2024
b8f5bd6
Maybe fix crashes
Sep 6, 2024
ce159ff
Remove package from test cases
Sep 9, 2024
a12e994
ugh
Sep 9, 2024
5051266
www
Sep 9, 2024
2bb2441
Ehh
Sep 9, 2024
85a32e1
Changes for AOT
Sep 11, 2024
dc4c3b9
Font test
Sep 12, 2024
d8134fa
Test font again
Sep 12, 2024
a31358a
Remove refs to winappsdk where it's not needed
Sep 24, 2024
9bb0d45
Fix some missing refs
Sep 24, 2024
c1963b0
Remove winappsdk ref in graphics projects
Sep 24, 2024
f9c8ef2
Add explcit "Microsoft.Windows.SDK.NET.Ref" versions
Sep 24, 2024
b8e170f
NOP failing test
Sep 25, 2024
4c405b1
- publish binlogs
PureWeen Sep 25, 2024
b2fee4b
- fix logs
PureWeen Sep 26, 2024
9080a5f
Update maui-templates.yml
PureWeen Sep 26, 2024
bc77e0d
Fix issue w/ dupe package contents
Sep 30, 2024
3f7d8e8
Merge branch 'foda/winappsdk16' of https://github.com/dotnet/maui int…
Sep 30, 2024
2515b69
Throwing stuff at the wall
Oct 1, 2024
876e382
Update winsdk and dotnet versions
Oct 1, 2024
39452a8
Revert SDK version
Oct 2, 2024
04cdc17
Merge branch 'net9.0' into foda/winappsdk16
Foda Oct 2, 2024
c54157a
Modify AOT compat check
Oct 2, 2024
1a1c57c
Merge branch 'foda/winappsdk16' of https://github.com/dotnet/maui int…
Oct 2, 2024
85f1aee
Re-add SDK.NET.Ref
Oct 3, 2024
b067735
Re-bump winappsdk version
Oct 3, 2024
ff134ab
Fix SDK pack version
Oct 3, 2024
5b797a0
Merge branch 'net9.0' into foda/winappsdk16
Foda Oct 3, 2024
a1c351a
Fix nested partial types
Oct 3, 2024
5af4206
Merge branch 'foda/winappsdk16' of https://github.com/dotnet/maui int…
Oct 3, 2024
09e1af4
DOh
Oct 3, 2024
b0381c9
Update test image
Oct 4, 2024
17ee733
Merge branch 'net9.0' into foda/winappsdk16
rmarinho Oct 4, 2024
bc60ef6
Update Directory.Build.targets
rmarinho Oct 5, 2024
237f4fa
Remove dupe properties
Oct 7, 2024
79c7d7a
Remove work-around
Oct 7, 2024
eff3a43
Fix merge issues
Oct 7, 2024
e122733
WTF?
Oct 7, 2024
d29d1cf
Blah
Oct 7, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ updates:
- "Microsoft.Graphics.Win2D"
- "Microsoft.Windows.SDK.BuildTools"
- "Microsoft.WindowsAppSDK"
- "Microsoft.Web.WebView2"
xunit:
patterns:
- "xunit"
Expand All @@ -57,7 +58,7 @@ updates:
- dependency-name: "Newtonsoft.Json" # needs to be done manually to match VS
- dependency-name: "Microsoft.Build*" # these packages neet to be kept on old version that supports netstandard2.0
- dependency-name: "Selenium.*" # needs to be done manually because other packages need to be compiled with these new versions

labels:
- "nuget"
- "dependencies"
Expand Down
12 changes: 7 additions & 5 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
<Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />
<Import Condition="'$(EnvironmentBuildPropsImported)' != 'True'" Project="$(MSBuildThisFileDirectory)eng\Environment.Build.props" />

<PropertyGroup>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<PropertyGroup>
<TreatWarningsAsErrors>false</TreatWarningsAsErrors>
PureWeen marked this conversation as resolved.
Show resolved Hide resolved
<DebugType>portable</DebugType>
<DebugSymbols>true</DebugSymbols>
<LangVersion>Latest</LangVersion>
Expand Down Expand Up @@ -40,13 +40,13 @@
<NuGetAuditMode>all</NuGetAuditMode>
<NuGetAuditLevel>moderate</NuGetAuditLevel>
</PropertyGroup>

<PropertyGroup>
<_MauiDotNetVersionMajor Condition="'$(_MauiDotNetVersionMajor)' == ''">9</_MauiDotNetVersionMajor>
<_MauiDotNetVersionMinor Condition="'$(_MauiDotNetVersionMinor)' == ''">0</_MauiDotNetVersionMinor>
<_MauiDotNetVersion Condition="'$(_MauiDotNetVersion)' == ''">$(_MauiDotNetVersionMajor).$(_MauiDotNetVersionMinor)</_MauiDotNetVersion>
<_MauiDotNetTfm Condition="'$(_MauiDotNetTfm)' == ''">net$(_MauiDotNetVersion)</_MauiDotNetTfm>

<_MauiPreviousDotNetVersionMajor Condition="'$(_MauiPreviousDotNetVersionMajor)' == ''">8</_MauiPreviousDotNetVersionMajor>
<_MauiPreviousDotNetVersionMinor Condition="'$(_MauiPreviousDotNetVersionMinor)' == ''">0</_MauiPreviousDotNetVersionMinor>
<_MauiPreviousDotNetVersion Condition="'$(_MauiPreviousDotNetVersion)' == ''">$(_MauiPreviousDotNetVersionMajor).$(_MauiPreviousDotNetVersionMinor)</_MauiPreviousDotNetVersion>
Expand Down Expand Up @@ -99,6 +99,8 @@
<IncludeIosTargetFrameworks>true</IncludeIosTargetFrameworks>
<IncludeCompatibilityProjects>false</IncludeCompatibilityProjects>
<IncludeCompatibilityProjects Condition="'$(SolutionFileName)' == 'Microsoft.Maui.sln'">true</IncludeCompatibilityProjects>

<WindowsSdkPackageVersion Condition="$([MSBuild]::IsOSPlatform('windows'))">10.0.19041.35-preview</WindowsSdkPackageVersion>
</PropertyGroup>

<!-- this is CI, so everything should be there -->
Expand Down Expand Up @@ -185,7 +187,7 @@
<_MauiBuildTasksLocation>$(_MauiBuildTasksLocation)</_MauiBuildTasksLocation>
<_MauiBuildTasksLocation Condition="'$(_MauiBuildTasksLocation)' == ''">$(MSBuildThisFileDirectory).buildtasks\</_MauiBuildTasksLocation>
<_MauiAOTProfileLocation>$(MauiSrcDirectory)Controls\src\Build.Tasks\nuget\buildTransitive\netstandard2.0\</_MauiAOTProfileLocation>
<StrongNamerKeyFile>$(MauiRootDirectory)eng/microsoft.maui.controls.snk</StrongNamerKeyFile>
<StrongNamerKeyFile>$(MauiRootDirectory)eng/microsoft.maui.controls.snk</StrongNamerKeyFile>
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
<ProduceReferenceAssembly Condition="'$(UsingMicrosoftNETSdk)' == 'True' AND '$(Configuration)' == 'Debug'">True</ProduceReferenceAssembly>
<ProduceReferenceAssemblyInOutDir>True</ProduceReferenceAssemblyInOutDir>
Expand Down
6 changes: 3 additions & 3 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
<TargetPlatformMinVersion>6.5</TargetPlatformMinVersion>
</PropertyGroup>

<!--
NOTE: The Contains('-windows10') is a bit of a hack
<!--
NOTE: The Contains('-windows10') is a bit of a hack
because we don't want to set these properties for WPF projects...
There's probably a better way we should find to infer this
-->
Expand All @@ -81,7 +81,7 @@

<!-- Until we get a new enough dotnet -->
<ItemGroup Condition="'$(_MauiTargetPlatformIsWindows)' == 'True'">
<FrameworkReference Update="Microsoft.Windows.SDK.NET.Ref" RuntimeFrameworkVersion="10.0.19041.31" TargetingPackVersion="10.0.19041.31" />
<FrameworkReference Update="Microsoft.Windows.SDK.NET.Ref" RuntimeFrameworkVersion="10.0.19041.35-preview" TargetingPackVersion="10.0.19041.35-preview" />
Foda marked this conversation as resolved.
Show resolved Hide resolved
</ItemGroup>

<!--
Expand Down
1 change: 1 addition & 0 deletions NuGet.config
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<!--End: Package sources managed by Dependency Flow automation. Do not edit the sources above.-->
<add key="local" value="LOCAL_PLACEHOLDER" />
<add key="nuget-only" value="NUGET_ONLY_PLACEHOLDER" />
<add key="nuget.org" value="https://api.nuget.org/v3/index.json"/>
PureWeen marked this conversation as resolved.
Show resolved Hide resolved
<add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" protocolVersion="3" />
<add key="dotnet-eng" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" protocolVersion="3" />
<add key="dotnet-public" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json" protocolVersion="3" />
Expand Down
9 changes: 5 additions & 4 deletions eng/NuGetVersions.targets
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,11 @@
Version="$(MicrosoftWindowsAppSDKPackageVersion)"
NoWarn="NU1605"
/>
<PackageReference
Update="Microsoft.Web.WebView2"
Version="$(MicrosoftWindowsWebView2PackageVersion)"
NoWarn="NU1605"
/>
<PackageReference
Update="Microsoft.Windows.SDK.BuildTools"
Version="$(MicrosoftWindowsSDKBuildToolsPackageVersion)"
Expand Down Expand Up @@ -250,10 +255,6 @@
Update="Microsoft.Bcl.AsyncInterfaces"
Version="$(MicrosoftBclAsyncInterfacesPackageVersion)"
/>
<PackageReference
Update="Microsoft.Web.WebView2"
Version="$(_MicrosoftWebWebView2Version)"
/>
<PackageReference
Update="Microsoft.CodeAnalysis.PublicApiAnalyzers"
Version="$(MicrosoftCodeAnalysisPublicApiAnalyzersVersion)"
Expand Down
4 changes: 2 additions & 2 deletions eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,10 @@
<MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion>9.0.0-rc.1.24402.2</MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion>
<MicrosoftNETWorkloadEmscriptenPackageVersion>$(MicrosoftNETWorkloadEmscriptenCurrentManifest90100TransportVersion)</MicrosoftNETWorkloadEmscriptenPackageVersion>
<!-- wasdk -->
<MicrosoftWindowsAppSDKPackageVersion>1.5.240627000</MicrosoftWindowsAppSDKPackageVersion>
<MicrosoftWindowsAppSDKPackageVersion>1.6.240807006-preview1</MicrosoftWindowsAppSDKPackageVersion>
<MicrosoftWindowsSDKBuildToolsPackageVersion>10.0.22621.756</MicrosoftWindowsSDKBuildToolsPackageVersion>
<MicrosoftGraphicsWin2DPackageVersion>1.2.0</MicrosoftGraphicsWin2DPackageVersion>
<MicrosoftWindowsWebView2PackageVersion>1.0.2651.64</MicrosoftWindowsWebView2PackageVersion>
<!-- Everything else -->
<MicrosoftAspNetCoreAuthorizationPackageVersion>9.0.0-rc.1.24408.9</MicrosoftAspNetCoreAuthorizationPackageVersion>
<MicrosoftAspNetCoreAuthenticationFacebookPackageVersion>9.0.0-rc.1.24408.9</MicrosoftAspNetCoreAuthenticationFacebookPackageVersion>
Expand Down Expand Up @@ -104,7 +105,6 @@
<SystemIOUnmanagedMemoryStreamPackageVersion>4.3.0</SystemIOUnmanagedMemoryStreamPackageVersion>
<SystemObjectModelPackageVersion>4.3.0</SystemObjectModelPackageVersion>
<SystemRuntimeCompilerServicesUnsafePackageVersion>6.0.0</SystemRuntimeCompilerServicesUnsafePackageVersion>
<_MicrosoftWebWebView2Version>1.0.2592.51</_MicrosoftWebWebView2Version>
<!-- GLIDE - the android maven artifact in /src/Core/AndroidNative/maui/build.gradle -->
<!-- must be kept in sync with the binding library version to it here: -->
<_XamarinAndroidGlideVersion>4.16.0.5</_XamarinAndroidGlideVersion>
Expand Down
1 change: 1 addition & 0 deletions src/Core/src/Core.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
<PackageReference Include="Microsoft.WindowsAppSDK" />
<PackageReference Include="Microsoft.Windows.SDK.BuildTools" />
<PackageReference Include="Microsoft.Graphics.Win2D" />
<PackageReference Include="Microsoft.Web.WebView2" />
<ProjectReference Include="..\..\Graphics\src\Graphics.Win2D\Graphics.Win2D.csproj" />
</ItemGroup>
<ItemGroup Condition="$(TargetFramework.Contains('-android'))">
Expand Down
1 change: 1 addition & 0 deletions src/Essentials/src/Essentials.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
<Compile Include="**\*.uwp.cs" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" />
<Compile Include="**\*.uwp.*.cs" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" />
<PackageReference Include="Microsoft.WindowsAppSDK" />
<PackageReference Include="Microsoft.Web.WebView2" />
</ItemGroup>
<ItemGroup Condition=" '$(TargetPlatformIdentifier)' == 'android' ">
<Compile Include="**\*.android.cs" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder)" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.WindowsAppSdk" />
<PackageReference Include="Microsoft.Graphics.Win2D" />
<PackageReference Include="Microsoft.Web.WebView2" />
<Manifest Include="$(ApplicationManifest)" />
</ItemGroup>

Expand Down
1 change: 1 addition & 0 deletions src/Graphics/src/Graphics.Win2D/Graphics.Win2D.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.WindowsAppSDK" />
<PackageReference Include="Microsoft.Graphics.Win2D" />
<PackageReference Include="Microsoft.Web.WebView2" />
</ItemGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/Graphics/src/Graphics/Graphics.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
<ItemGroup Condition="$(TargetFramework.Contains('-windows'))">
<PackageReference Include="Microsoft.WindowsAppSDK" />
<PackageReference Include="Microsoft.Graphics.Win2D" />
<PackageReference Include="Microsoft.Web.WebView2" />
</ItemGroup>

<Import Project="$(MauiSrcDirectory)Workload\Shared\LibraryPacks.targets" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
<_ValuesToReplace Include="MAUI_PREVIOUS_DOTNET_VERSION_NO_DOT" PropertyName="_MauiPreviousDotNetVersionNoDot" />
<_ValuesToReplace Include="MAUI_PREVIOUS_DOTNET_RELEASED_NUGET_VERSION" PropertyName="MicrosoftMauiPreviousDotNetReleasedVersion" />
<_ValuesToReplace Include="MicrosoftWindowsAppSDKPackageVersion" PropertyName="MicrosoftWindowsAppSDKPackageVersion" />
<_ValuesToReplace Include="MicrosoftWindowsWebView2PackageVersion" PropertyName="MicrosoftWindowsWebView2PackageVersion" />
<_ValuesToReplace Include="TizenUIExtensionsVersion" PropertyName="TizenUIExtensionsVersion" />
<_ValuesToReplace Include="_XamarinAndroidGlideVersion" PropertyName="_XamarinAndroidGlideVersion" />
<_ValuesToReplace Include="_XamarinAndroidXSecurityVersion" PropertyName="_XamarinAndroidXSecurityVersion" />
Expand Down
Loading