Fixed FlyoutItemIsVisible is not working with bindings #24212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @dhindrik! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dhindrik
changed the title
|
Since this introduces new APIs this should go into net9. Can you maybe retarget to the net9.0 branch? |
What is the best way to do it? I tried to change the PR, but then a lot of other commits were added to the PR. It would also be great to have this out before .net 9. But I guess not many people are using it like I want because I did not find any issues with it. |
dhindrik
force-pushed
the
24203-FlyoutItemIsVisible-is-not-working-with-bindings
branch
from
cb946e4
to
f041ff3
Compare
|
@jfversluis I think I managed to fix it. It was easier than I thought. Is everything looking correct? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Aug 13, 2024
… for FlyoutItemIsVisible in BaseShellItem
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Aug 22, 2024
dhindrik
deleted the
24203-FlyoutItemIsVisible-is-not-working-with-bindings
branch
samhouts
added
the
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In the property for FlyoutItemIsVisible it used Shell.FlyoutItemIsVisibleProperty which is an attached property in the Shell class. But that will not work when trying to bind to FlyoutItemIsVisible because with bindings it is expected to find FlyoutItemIsVisibleProperty in the BaseShellItem class.
In the OnFlyoutItemIsVisibleChanged method I called the Shell.SetFlyoutItemIsVisible to update the attached property that was updated directly in the property before.
Issues Fixed
Fixes #24203