[Windows] Fix Entry clear button is not taking the color of the text. #24196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on keys in TextColorResourceKeys list.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@BagavathiPerumal I think you need to accept CLA (see #24196 (comment)) first. |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jfversluis
previously approved these changes
Aug 20, 2024
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Foda
approved these changes
Aug 23, 2024
PureWeen
approved these changes
Aug 26, 2024
|
@BagavathiPerumal can you agree with the CLA even if you did it already somewhere else just to see if that gets is unstuck? |
|
@dotnet-policy-service agree |
samhouts
added
the
fixed-in-net8.0-nightly
samhouts
added
the
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
and removed
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
The Clear button in the Entry control does not match the TextColor settings because the TextBoxExtension is missing the necessary keys for the ClearButton in the TextColorResourceKeys list. The keys only cover the text colors for the Entry control and do not include the Clear button.
Description of Issue Fix
The fix involves adding additional resource keys for the Clear button’s foreground colors. This ensures that the Clear button correctly adopts the specified text colors for different states, such as pointer over and pressed.
Issues Fixed
Fixes #19152
Output
Before Fix:
After Fix: