Shell Tab is still visible after set Tab.IsVisible to false #24161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@SuthiYuvaraj anything I can help you with for this one? |
PureWeen
requested changes
Aug 15, 2024
|
@dotnet-policy-service agree |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Aug 23, 2024
| @@ -0,0 +1,24 @@ | |||
| #if ANDROID | |||
There was a problem hiding this comment.
Can we run this test on iOS and Windows also?
I realize the bug only talks about android but since this code is relevant on all platforms, it's ideal to have a test that runs on all three
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Aug 29, 2024
rmarinho
reviewed
Aug 31, 2024
| @@ -357,6 +357,10 @@ void GoTo(ShellSection shellSection) | |||
| if (shellSection == null || _currentSection == shellSection) | |||
| return; | |||
| var renderer = RendererForShellContent(shellSection); | |||
|
|
|||
| if (renderer == null) | |||
There was a problem hiding this comment.
Next time when we can lets use the is null .
rmarinho
approved these changes
Aug 31, 2024
|
Failing test not related |
SuthiYuvaraj
changed the title
samhouts
added
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
and removed
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
When the visibility of the TabItem is changed dynamically, TabBar needs to be updated to reflect the TabBar items count, but hiding the visible TabItem updates the TabContent but doesn't automatically adjust the tab count.
Description of Change
Each time the DisplayedPage is modified,we have updated the TabBar items count through setupmenu().
Issues Fixed
Fixes #8788
Fixes #23717
Fixes #23780
Screenshots
Before:
Recording.2024-08-20.130548.mp4
After:
Recording.2024-08-20.130401.mp4