Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct "can not" to "cannot" in messages, comments, etc. #24124

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Eilon
Copy link
Member

@Eilon Eilon commented Aug 9, 2024

Both are correct, but "cannot" is preferred and far more common: https://www.merriam-webster.com/grammar/cannot-vs-can-not-is-there-a-difference

In some cases it is a user-facing message, such as certain XAML errors:

throw new XamlParseException($"Can not find the object referenced by `{Name}`", serviceProvider);

And if you run into this type of error, you see it in Visual Studio. And it looks weird.

@spadapet , @jfversluis , @jonathanpeppers , @Redth - tagging all of you because you were participating in my discussion of this in a recent meeting. Very easy PR to review!

Notes:

  • I'm submitting to net9 because this is ultimately minor.
  • I left a few instances of can not in the repo because they are quoting other things like bug titles, so I left them as-is.

Both are correct, but "cannot" is preferred and far more common.
@Eilon Eilon requested a review from a team as a code owner August 9, 2024 19:20
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot disapprove.

Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i-cannot-spock

@Eilon Eilon added the area-xaml XAML, CSS, Triggers, Behaviors label Aug 9, 2024
@Eilon Eilon enabled auto-merge (squash) August 9, 2024 20:38
@jfversluis
Copy link
Member

OK I think after 6 attempts maybe something is actually wrong with the still failing test...

@rmarinho rmarinho disabled auto-merge August 12, 2024 17:57
@rmarinho rmarinho merged commit 11a6d6f into net9.0 Aug 12, 2024
115 of 117 checks passed
@rmarinho rmarinho deleted the eilon/can-not-cannot branch August 12, 2024 17:57
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Aug 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-xaml XAML, CSS, Triggers, Behaviors fixed-in-net9.0-nightly This may be available in a nightly release!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants