[Windows] Fix Span Foreground property #24063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Works great!! Once the tests are added this should be good to merge |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Aug 8, 2024
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue23488.cs
Outdated
Show resolved
Hide resolved
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Aug 9, 2024
jfversluis
approved these changes
Aug 10, 2024
Foda
approved these changes
Aug 12, 2024
|
@dotnet-policy-service agree |
Redth
pushed a commit
that referenced
this pull request
Aug 22, 2024
* 23448 - Span text-decoration is incorrect whereas the Label behaves properly. * added UITest - 23488 * AutomationId added. * updated namespace properly. * Output images added.
samhouts
added
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.1.24453.9
and removed
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The label uses the run element in WinUI platform while using formatted text. The label text color is applied to the text highlighter of the run element, which updates the run text color, but to update the underline color of hypertext, the run Foreground property needs to be updated, which was missed.
Description of Issue Fix
The fix involved updating the run Foreground property to ensure the underline color of hypertext is also updated, preventing it from remaining unchanged from the default.
Issues Fixed
Fixes #23488
Screenshots
Before
After
