Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run device tests on the previous TFMs #23896

Closed
wants to merge 40 commits into from
Closed

Run device tests on the previous TFMs #23896

wants to merge 40 commits into from

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Jul 29, 2024 •
edited
Loading

Description of Change

Build the previous TFMs to allow for early testing of APIs.

Just like the way we build .NET 8 TFMs for Essentials and Graphics on the net9.0, this PR just extends the logic to also build .NET 8 for all projects.

This is very late now and maybe not super valuable, but still good to get in so we can test. For .NET 10, this will be very helpful so people can test and play with .NET MAUI 10 APIs with the .NET 9 stable SDK.

@mattleibow mattleibow requested review from a team as code owners July 29, 2024 15:28
@mattleibow mattleibow force-pushed the dev/net8-in-net9 branch 4 times, most recently from 7d5a947 to 37d60a2 Compare July 31, 2024 13:15
@samhouts samhouts added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Jul 31, 2024
@mattleibow mattleibow force-pushed the dev/net8-in-net9 branch 3 times, most recently from b1ad8ba to df3e1d6 Compare July 31, 2024 19:32
@PureWeen PureWeen added this to the 9.0-preview7 milestone Aug 5, 2024
jonathanpeppers
jonathanpeppers reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put what this is trying to do in the description? I don't know what I would be reviewing here.

jonathanpeppers
jonathanpeppers reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I wonder if things even work on .NET 8, as we depend on several "new" features that might be .NET 9-only:

src/Compatibility/Core/src/Android/AppCompat/FormsFragmentPagerAdapter.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Platform/Android/MultiPageFragmentStateAdapter.cs Outdated Show resolved Hide resolved
src/TestUtils/src/Microsoft.Maui.IntegrationTests/TemplateTests.cs Outdated
Comment on lines 41 to 43
// TODO: remove this if as we should be able to build tizen net8
if (framework != DotNetPrevious)
EnableTizen(projectFile);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we indent this line, or put { } around it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a temporary fix for now until Tizen fixes their workloads. Right now there is an issue and I am still working with them to get it fixed - hopefully in the RCs

src/TestUtils/src/Microsoft.Maui.IntegrationTests/TemplateTests.cs Outdated Show resolved Hide resolved
src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellSearchViewAdapter.cs Outdated Show resolved Hide resolved
jonathanpeppers
jonathanpeppers previously approved these changes Aug 5, 2024
View reviewed changes
@mattleibow mattleibow mentioned this pull request Aug 7, 2024
Closed
@mattleibow
Copy link
Member Author

This is a previous run of device tests with net8 and net9 - all green basically: https://dev.azure.com/xamarin/public/_build/results?buildId=121055&view=results

@mattleibow
Copy link
Member Author

I see this PR was merged into preview7 already: #24041

This PR is now going to just become a PR to add a bunch of extra device tests and template tests to cover all the new cases in the matrix of amazement that is maui.

@mattleibow
Remove xcsync as it is too big for CI
70544ae 
Part of #24094
@mattleibow
Merge branch 'dev/merge-pre7-into-net9' into dev/net8-in-net9
5f91f8a 
# Conflicts:
#	eng/Versions.props
#	eng/pipelines/common/maui-templates.yml
#	eng/pipelines/device-tests.yml
#	src/TestUtils/src/Microsoft.Maui.IntegrationTests/TemplateTests.cs
@mattleibow mattleibow changed the base branch from net9.0 to dev/merge-pre7-into-net9 August 8, 2024 17:44
Base automatically changed from dev/merge-pre7-into-net9 to net9.0 August 8, 2024 21:54
@PureWeen PureWeen modified the milestones: 9.0-preview7, 9.0-rc1 Aug 12, 2024
@mattleibow
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mattleibow
Copy link
Member Author

/rebase

@mattleibow mattleibow changed the title Build the previous TFMs Add tests for when building the previous TFMs Aug 21, 2024
@mattleibow mattleibow changed the title Add tests for when building the previous TFMs Add device tests for when building the previous TFMs Aug 21, 2024
@mattleibow mattleibow changed the title Add device tests for when building the previous TFMs Run device tests on the previous TFMs Aug 21, 2024
@PureWeen PureWeen modified the milestones: 9.0-rc1, 9.0-rc2 Aug 24, 2024
@PureWeen
Copy link
Member

We've turned this feature off for net9

#24488

So for now I'm going to close this

Once we start rolling net10 we can add this into net10

@PureWeen PureWeen closed this Sep 23, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen left review comments

@jonathanpeppers jonathanpeppers jonathanpeppers left review comments

@Eilon Eilon Awaiting requested review from Eilon Eilon is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions
Projects
MAUI SDK Ongoing
Status: Done
Milestone
9.0-rc2
Development

Successfully merging this pull request may close these issues.
5 participants
@mattleibow @PureWeen @jonathanpeppers @samhouts @dalexsoto