[ci] Fix maestro publishing for stable packages #23664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen the build promotion pipeline fail when trying to publish
stable package versions:
error : Package 'Microsoft.AspNetCore.Components.WebView.Maui' has stable version '8.0.60' but is targeted at a non-isolated feed 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json'
This is because we were not declaring these packages as stable when
building the build asset registry manifest.
Fix this by passing the `$(StabilizePackageVersion)` property to the
build asset manifest creation task. This property needs to be updated
manually when switching to stable package versioning (see 4eab956220b).
When `$(StabilizePackageVersion)` is set to true, packages will be
pushed to an isolated feed during publishing, such as:
Package [email protected] (Shipping) should go to https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-android-b8317b6f/nuget/v3/index.json (Isolated, Public)
pjcollins
added
the
area-infrastructure
rmarinho
approved these changes
Jul 17, 2024
|
We might want this on main |
I know you ran into this on some .NET 8 builds previously, but wasn't sure if you had already fixed this there? Should be safe to backport if the other changes from 0a0be96 are already on older branches and causing this issue with stable packages. |
rmarinho
pushed a commit
that referenced
this pull request
Jul 18, 2024
We've seen the build promotion pipeline fail when trying to publish
stable package versions:
error : Package 'Microsoft.AspNetCore.Components.WebView.Maui' has stable version '8.0.60' but is targeted at a non-isolated feed 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json'
This is because we were not declaring these packages as stable when
building the build asset registry manifest.
Fix this by passing the `$(StabilizePackageVersion)` property to the
build asset manifest creation task. This property needs to be updated
manually when switching to stable package versioning (see 4eab956220b).
When `$(StabilizePackageVersion)` is set to true, packages will be
pushed to an isolated feed during publishing, such as:
Package [email protected] (Shipping) should go to https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-android-b8317b6f/nuget/v3/index.json (Isolated, Public)
rmarinho
added a commit
that referenced
this pull request
Jul 18, 2024
We've seen the build promotion pipeline fail when trying to publish
stable package versions:
error : Package 'Microsoft.AspNetCore.Components.WebView.Maui' has stable version '8.0.60' but is targeted at a non-isolated feed 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json'
This is because we were not declaring these packages as stable when
building the build asset registry manifest.
Fix this by passing the `$(StabilizePackageVersion)` property to the
build asset manifest creation task. This property needs to be updated
manually when switching to stable package versioning (see 4eab956220b).
When `$(StabilizePackageVersion)` is set to true, packages will be
pushed to an isolated feed during publishing, such as:
Package [email protected] (Shipping) should go to https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-android-b8317b6f/nuget/v3/index.json (Isolated, Public)
Co-authored-by: Peter Collins <[email protected]>
samhouts
added
the
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen the build promotion pipeline fail when trying to publish
stable package versions:
This is because we were not declaring these packages as stable when
building the build asset registry manifest.
Fix this by passing the
$(StabilizePackageVersion)property to thebuild asset manifest creation task. This property needs to be updated
manually when switching to stable package versioning (see b956220).
When
$(StabilizePackageVersion)is set to true, packages will bepushed to an isolated feed during publishing, such as: