Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell BackButtonBehavior improvement #23466

Merged
merged 4 commits into from
Jul 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ void UpdateLeftToolbarItems()
if (!IsRootPage)
{
NavigationItem.HidesBackButton = !backButtonVisible;
kubaflo marked this conversation as resolved.
Show resolved Hide resolved
image = backButtonVisible ? image : null;
}

image.LoadImage(MauiContext, result =>
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
35 changes: 35 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue23424.xaml.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
namespace Maui.Controls.Sample.Issues;

[XamlCompilation(XamlCompilationOptions.Compile)]
[Issue(IssueTracker.Github, "23424", "BackButtonBehavior IsVisible=False does not hide the back button", PlatformAffected.All)]
public partial class Issue23424 : Shell
{
public Issue23424()
{
Items.Add(new ContentPage());
Navigation.PushAsync(new DetailPage());
}

public class DetailPage : ContentPage
{
public DetailPage()
{
Title = "Detail page";
BackButtonBehavior backButtonBehavior = new BackButtonBehavior
{
IconOverride = "small_dotnet_bot.png"
};

SetBackButtonBehavior(this, backButtonBehavior);
Content = new VerticalStackLayout()
{
new Button()
{
AutomationId = "button",
Text = "Click to hide the back button",
Command = new Command(()=>backButtonBehavior.IsVisible =! backButtonBehavior.IsVisible)
}
};
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
#if !MACCATALYST
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

namespace Microsoft.Maui.TestCases.Tests.Issues
{
public class Issue23424: _IssuesUITest
{
public Issue23424(TestDevice device) : base(device)
{
}

public override string Issue => "BackButtonBehavior IsVisible=False does not hide the back button";

[Test]
[Category(UITestCategories.Shell)]
public void BackButtonBehaviorIsVisibleWorksWithCustomIcon()
{
App.WaitForElement("button");
App.Click("button");

// The test passes if the back button is not visible
VerifyScreenshot();
}
}
}
#endif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading