Null terminate iOS TabbedRenderer #23289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
requested review from
Eilon and
StephaneDelcroix
and removed request for
a team
PureWeen
force-pushed
the
testing_failures
branch
from
0310617
to
ec17cb3
Compare
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/backport to main |
|
Started backporting to main: https://github.com/dotnet/maui/actions/runs/9688067581 |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/rebase |
|
Device Tests failing to run because of feed issues Tests passed for these changes here |
|
/backport to net9.0 |
|
Started backporting to net9.0: https://github.com/dotnet/maui/actions/runs/9712696411 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We recently made the xplat view inside
TabbedRendererweak so there are scenarios where life cycle events might trigger a path that tries to retrieve a collected xplat view. I noticed this failure in our device tests when running locally. Occasionally it would be fine but occasionally it wouldn't :-)