Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Update to Appium 5.0.0 #23118

Merged
merged 2 commits into from
Jun 18, 2024
Merged

[Tests] Update to Appium 5.0.0 #23118

merged 2 commits into from
Jun 18, 2024

Commits on Jun 18, 2024

  1. Update to appium 5.0.0 

    Their driver has some removed methods (LaunchApp/CloseApp) which seem to be now implemented for windows.

Also removed an extra explicit ref to system.drawing.common since it comes in transitively from appium.webdriver package (and the version was causing issues since the newer appium.webdriver uses a newer version).
    @Redth
    Redth committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    6632172 View commit details
    Browse the repository at this point in the history

  2. Fix windows launchapp/closeapp for newer appium 

    In Appium's dotnet driver in v5.0.0 they removed `LaunchApp` from the driver: appium/dotnet-client#766

The deprecation suggests using `ActivateApp` as an alternative, but that throws an error saying it's not implemented on the windows driver.

Curiously, `CloseApp` which was also marked as deprecated was _moved_ from the base appium driver to the `WindowsDriver` here: appium/dotnet-client#773

I think the same treatment should have been done to the `LaunchApp` method since there's no alternative in windows.

For now the workaround is to invoke the command manually:
`windowsDriver.ExecuteScript("windows: launchApp", [_app.GetAppId()]);`
    @Redth
    Redth committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    bfe57d8 View commit details
    Browse the repository at this point in the history