Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Allow custom handler with key listener #22546

Merged
merged 5 commits into from
May 22, 2024
Merged

[Android] Allow custom handler with key listener #22546

merged 5 commits into from
May 22, 2024

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Allow custom handler with key listener.
fix-21109
Verified that the ReturnType property keeps working correctly.

Issues Fixed

Fixes #21109

@jsuarezruiz jsuarezruiz requested a review from a team as a code owner May 21, 2024 10:59
mattleibow
mattleibow reviewed May 21, 2024
View reviewed changes
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just got a few comments on where things maybe can go to avoid the spaghettiverse

src/Controls/tests/TestCases/Issues/Issue21109.xaml.cs Outdated Show resolved Hide resolved
src/Controls/tests/TestCases/MauiProgram.cs Outdated Show resolved Hide resolved
src/Core/src/Handlers/Entry/EntryHandler.Android.cs Show resolved Hide resolved
@mattleibow mattleibow merged commit 3c58cf1 into main May 22, 2024
49 checks passed
@mattleibow mattleibow deleted the fix-21109 branch May 22, 2024 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-controls-entry Entry fixed-in-8.0.60 fixed-in-9.0.0-preview.5.24307.10 platform/android 🤖 t/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Android] MAUI 8.0.3 -> 8.0.6 regression: custom handler with key listener no longer works
3 participants
@jsuarezruiz @mattleibow @samhouts