Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory Leak in Style with Trigger - fix #22503

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Memory Leak in Style with Trigger - fix #22503

merged 2 commits into from
Jun 3, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented May 18, 2024

Issues Fixed

Fixes #22036

@kubaflo kubaflo requested a review from a team as a code owner May 18, 2024 13:50
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label May 18, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz jsuarezruiz added the area-xaml XAML, CSS, Triggers, Behaviors label May 20, 2024
jsuarezruiz
jsuarezruiz reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include a related test?
Here you can find an example:

maui/src/Controls/tests/Xaml.UnitTests/Issues/Maui21839.xaml.cs

Line 64 in 60a46c5

Assert.IsNull(pagewr.Target, "Page leaked");
Let me know if can help in something :)

@kubaflo
Copy link
Contributor Author

kubaflo commented May 20, 2024

Could you include a related test? Here you can find an example:

maui/src/Controls/tests/Xaml.UnitTests/Issues/Maui21839.xaml.cs

Line 64 in 60a46c5

Assert.IsNull(pagewr.Target, "Page leaked");

Let me know if can help in something :)

@jsuarezruiz I've added a test :)

MartyIX
MartyIX reviewed May 21, 2024
View reviewed changes
src/Controls/tests/Xaml.UnitTests/Issues/Maui22036.xaml.cs

var pagewr = new WeakReference(new Maui22036(useCompiledXaml));
await Task.Delay(10);
GC.Collect();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this more like: https://github.com/dotnet/maui/pull/22089/files#diff-019cd78242a7f184cefaf9a038f5e6414e6ad752f710d37c9cdc9ca6df66febdR92 ?

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen merged commit c62fc0d into dotnet:main Jun 3, 2024
49 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

@MartyIX MartyIX MartyIX left review comments

@StephaneDelcroix StephaneDelcroix StephaneDelcroix approved these changes

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-xaml XAML, CSS, Triggers, Behaviors community ✨ Community Contribution fixed-in-8.0.60 fixed-in-9.0.0-preview.5.24307.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Memory Leak in Style with Trigger
6 participants
@kubaflo @jsuarezruiz @MartyIX @StephaneDelcroix @PureWeen @samhouts