[UI Test] Update Appium to 5.0.0-rc.8 #22117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
reviewed
Apr 29, 2024
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| _app.Driver.LaunchApp(); | ||
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| } | ||
| else | ||
| { | ||
| _app.Driver.ActivateApp(_app.GetAppId()); |
There was a problem hiding this comment.
Does the new code path now work with packaged and unpakcaged apps?
There was a problem hiding this comment.
Take a look to #22117 (comment)
jsuarezruiz
commented
May 7, 2024
| else if (_app.GetTestDevice() == TestDevice.Windows) | ||
| { | ||
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| _app.Driver.LaunchApp(); |
There was a problem hiding this comment.
LaunchApp have been removed.
Cannot execute the launchApp script because not exists.
_app.Driver.ExecuteScript("windows: launchApp", new Dictionary<string, object>());
And ActivateApp is not implemented.
if(_app.Driver is WindowsDriver windowsDriver)
windowsDriver.ActivateApp(_app.GetAppId());
The alternative could be to quit the session and create a new one, but it is a bigger change. The Windows tests are going to fail until fix this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Update Appium to 5.0.0-rc.8.
https://dev.azure.com/dnceng/internal/_build/results?buildId=2440349&view=results