Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Removing TapGestureRecognizer with at least 2 taps causes Exception - fix #21714

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Apr 8, 2024

Issues Fixed

Fixes #21437

Before After
before.mov
after.mov

@kubaflo kubaflo requested a review from a team as a code owner April 8, 2024 23:02
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Apr 8, 2024
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@rmarinho
Copy link
Member

rmarinho commented Apr 9, 2024

/azp run MAUI-UITests-public

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rmarinho
Copy link
Member

rmarinho commented Apr 9, 2024

Why does it happen only with more than 2 taps ?

_ = App.WaitForElement("Item2");
App.DoubleClick("Item2");

//The test passes if no exception is thrown
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could update a Label text double clicking and verify the updated text here; but without crash this is enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test enough then?

@kubaflo
Copy link
Contributor Author

kubaflo commented Apr 10, 2024

Why does it happen only with more than 2 taps ?

I suspect it is because of this constructor:

// This is needed because GestureRecognizer callbacks can be delayed several hundred milliseconds

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot Jun 13, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz previously approved these changes Jun 13, 2024
@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen enabled auto-merge (squash) August 17, 2024 21:24
@PureWeen PureWeen merged commit 61e984e into dotnet:main Aug 17, 2024
97 checks passed
@samhouts samhouts added fixed-in-net9.0-nightly This may be available in a nightly release! fixed-in-net8.0-nightly This may be available in a nightly release! labels Aug 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-gestures Gesture types community ✨ Community Contribution fixed-in-net8.0-nightly This may be available in a nightly release! fixed-in-net9.0-nightly This may be available in a nightly release! platform/android 🤖
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing TapGestureRecognizer with at least 2 taps causes Exception
5 participants