Add unit test for button images in layouts #21651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @molesmoke! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
molesmoke
force-pushed
the
flexlayout-cycle-devicetest
branch
from
f337e28
to
f802d74
Compare
|
@Foda Hope a device test is helpful, even if I don't know how to fix the actual issue without just reverting previous changes |
Adds a skipped test for dotnet#21548 due to a regression caused by dotnet#20949
molesmoke
force-pushed
the
flexlayout-cycle-devicetest
branch
from
f802d74
to
1f8377c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
I removed the skip so we can see if our latest changes have fixed it. |
|
/azp run |
|
Forgot to run the tests |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
May 10, 2024
rmarinho
approved these changes
May 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds a skipped test for #21548 due to a regression caused by #20949
Issues Fixed
None, somebody else will need to fix the actual issue, but it can at least prevent future regressions