Add Apple Privacy Manifest to new project template #21350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
platform/iOS 🍎
area-templates
mcumming
previously approved these changes
Mar 22, 2024
Eilon
previously requested changes
Mar 22, 2024
dotMorten
reviewed
Mar 28, 2024
dotMorten
reviewed
Apr 5, 2024
src/Templates/src/templates/maui-blazor/Platforms/iOS/PrivacyInfo.xcprivacy
Outdated
Show resolved
Hide resolved
jfversluis
force-pushed
the
privacy-manifest-template
branch
from
228438b
to
b97cd72
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jfversluis
force-pushed
the
privacy-manifest-template
branch
2 times, most recently
from
09a8203
to
9cef0f5
Compare
dotMorten
reviewed
Jun 28, 2024
jfversluis
force-pushed
the
privacy-manifest-template
branch
from
9cef0f5
to
9ddf1b8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
approved these changes
Jul 1, 2024
jfversluis
dismissed
Eilon’s stale review
The piece of code it was about was entirely removed
Redth
approved these changes
Jul 2, 2024
dalexsoto
added a commit
that referenced
this pull request
Jul 25, 2024
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2172694 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2172757 This PR #21350 added the new `PrivacyInfo.xcprivacy` to our default templates (new requirement from Apple) when building from Windows we try to bundle this resource and unfortunately we are missing the required Link metadata when this is done from single project triggering a condition where the path is incorrectly calculated when zipped in windows and once the zip archive is transfered to the mac host it is unable to unarchive the file. To fix this we simply unify the logic with what the macios SDK currently does [1] this ensures the right bundling happens. [1]: https://github.com/xamarin/xamarin-macios/blob/main/dotnet/targets/Microsoft.Sdk.DefaultItems.template.props#L77
github-actions bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2172694 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2172757 This PR #21350 added the new `PrivacyInfo.xcprivacy` to our default templates (new requirement from Apple) when building from Windows we try to bundle this resource and unfortunately we are missing the required Link metadata when this is done from single project triggering a condition where the path is incorrectly calculated when zipped in windows and once the zip archive is transfered to the mac host it is unable to unarchive the file. To fix this we simply unify the logic with what the macios SDK currently does [1] this ensures the right bundling happens. [1]: https://github.com/xamarin/xamarin-macios/blob/main/dotnet/targets/Microsoft.Sdk.DefaultItems.template.props#L77
PureWeen
added a commit
that referenced
this pull request
Jul 25, 2024
…nd MacCatalyst (#23836) * [msbuild] Fix BundleResource defaults for iOS and MacCatalyst Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2172694 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2172757 This PR #21350 added the new `PrivacyInfo.xcprivacy` to our default templates (new requirement from Apple) when building from Windows we try to bundle this resource and unfortunately we are missing the required Link metadata when this is done from single project triggering a condition where the path is incorrectly calculated when zipped in windows and once the zip archive is transfered to the mac host it is unable to unarchive the file. To fix this we simply unify the logic with what the macios SDK currently does [1] this ensures the right bundling happens. [1]: https://github.com/xamarin/xamarin-macios/blob/main/dotnet/targets/Microsoft.Sdk.DefaultItems.template.props#L77 * Update Versions.props --------- Co-authored-by: Alex Soto <[email protected]> Co-authored-by: Shane Neuville <[email protected]>
PureWeen
pushed a commit
that referenced
this pull request
Jul 25, 2024
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2172694 Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2172757 This PR #21350 added the new `PrivacyInfo.xcprivacy` to our default templates (new requirement from Apple) when building from Windows we try to bundle this resource and unfortunately we are missing the required Link metadata when this is done from single project triggering a condition where the path is incorrectly calculated when zipped in windows and once the zip archive is transfered to the mac host it is unable to unarchive the file. To fix this we simply unify the logic with what the macios SDK currently does [1] this ensures the right bundling happens. [1]: https://github.com/xamarin/xamarin-macios/blob/main/dotnet/targets/Microsoft.Sdk.DefaultItems.template.props#L77
samhouts
added
fixed-in-8.0.70
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This adds the Apple Privacy Manifest, minimal version needed for a .NET MAUI app, to the default templates so that people don't have to add this manually.
One of the entries is commented out by default, when not explicitly using the Preferences APIs this is not needed as it will be trimmed when you publish your app. If you do use the Preferences APIs, uncomment the entry.
More information: https://aka.ms/maui-privacy-manifest
If you find this and are wondering how to deal with this in your already existing project: you should be able to take the contents from the
PrivacyInfo.xcprivacyfile and put that in your project. Then make sure that that file ends up in the root of your app bundle, this PR also shows you what changes to make for that in your csproj.