Enable .NET 7 <MauiVersion> to work in .NET 8 SDK projects #17409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
force-pushed
the
dev/mauiversion
branch
from
e7327ee
to
f687a72
Compare
|
/rebase |
github-actions
bot
force-pushed
the
dev/mauiversion
branch
from
f687a72
to
e975895
Compare
jonathanpeppers
previously approved these changes
Sep 21, 2023
|
/rebase |
github-actions
bot
force-pushed
the
dev/mauiversion
branch
from
e975895
to
06f1664
Compare
PureWeen
requested changes
Sep 25, 2023
rmarinho
reviewed
Sep 26, 2023
src/TestUtils/src/Microsoft.Maui.IntegrationTests/BaseBuildTest.cs
Outdated
Show resolved
Hide resolved
mattleibow
dismissed
jonathanpeppers’s stale review
The base branch was changed.
mattleibow
force-pushed
the
dev/mauiversion
branch
from
06f1664
to
d556132
Compare
PureWeen
approved these changes
Sep 26, 2023
samhouts
reviewed
Sep 26, 2023
| @@ -6,6 +6,9 @@ public class BaseBuildTest | |||
| public const string DotNetCurrent = "net8.0"; | |||
| public const string DotNetPrevious = "net7.0"; | |||
|
|
|||
| public const string MauiVersionCurrent = "8.0.0-rc.1.9171"; // this should not be the same as the last release | |||
There was a problem hiding this comment.
This comment is confusing. Do you mean it should not be the same as MauiVersionPrevious?
There was a problem hiding this comment.
Yeah, that was confusing. I'll fix.
samhouts
approved these changes
Sep 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
For .NET 7, we had MauiVersion as a way to control the version of maui to use. When we moved to .NET 8, this still works - but for the .NET 8 workload.
However, if you have a .NET 8 SDK and use a .NET 7 TFM, the MauiVersion still only applies to .NET 8.
This PR makes it work again for .NET 7 TFMs on a .NET 8 SDK. My initial fears of a .NET 7 MauiVersion breaking the .NET 8 workload were unfounded as the .NET 7 TFM only loads the .NET 7 maui targets - this means that when you set a number, it still only affects the .NET 7 maui. The reverse is also true, the build still works with this change because the block to load the .NET 7 framework references only applies to .NET 7 and thus will not load accidentally.
If you use a .NET 8 number for a .NET 7 TFM, the compiler complains that there are missing packs and thins is expected - there is no .NET 7 maui workload SDK for .NET 8 TFMs.