[net9.0] Shift platforms specific code from HybridWebView to the handler using Command Mappers #24269
Assignees
Labels
area-controls-hybridwebview
HybridWebView control
fixed-in-9.0.0-rc.2.24503.2
s/triaged
Issue has been reviewed
Task
neither bug nor feature but something that needs to be done in support of either
Milestone
Comments
|
See also: #23769 (review) |
samhouts
added
the
Task
Eilon
added a commit
that referenced
this issue
Aug 27, 2024
And run everything through the mappers. Fixes #24269
Eilon
added a commit
that referenced
this issue
Sep 11, 2024
And run everything through the mappers. Fixes #24269
rmarinho
pushed a commit
that referenced
this issue
Sep 23, 2024
* Move HybridWebView platform code to handlers And run everything through the mappers. Fixes #24269 * WIP * Fix API files * API * API * API * Change platform checks
Eilon
added a commit
that referenced
this issue
Sep 26, 2024
And run everything through the mappers. Fixes #24269
PureWeen
pushed a commit
that referenced
this issue
Oct 1, 2024
* Move HybridWebView platform code to handlers And run everything through the mappers. Fixes #24269 * Run Android tests * `@android.webkit.JavascriptInterface` is missing! By changing `HybridJavaScriptInterface` to a class, the JCW now says: @android.webkit.JavascriptInterface public void sendMessage (java.lang.String p0) --------- Co-authored-by: Jonathan Peppers <[email protected]>
github-actions bot
pushed a commit
that referenced
this issue
Oct 1, 2024
And run everything through the mappers. Fixes #24269
rmarinho
pushed a commit
that referenced
this issue
Oct 2, 2024
…ttempt 2) (#25041) * Move HybridWebView platform code to handlers And run everything through the mappers. Fixes #24269 * Run Android tests * `@android.webkit.JavascriptInterface` is missing! By changing `HybridJavaScriptInterface` to a class, the JCW now says: @android.webkit.JavascriptInterface public void sendMessage (java.lang.String p0) --------- Co-authored-by: Eilon Lipton <[email protected]> Co-authored-by: Jonathan Peppers <[email protected]>
|
I believe this is all done now? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
#23769 (review)
The code here should use the CommandMapper pattern
https://github.com/dotnet/maui/blob/net9.0/src/Controls/src/Core/HybridWebView/HybridWebView.cs#L122
The best example of this is probably
IScrollViewThere's a request you can make to the
CommandMApperAnd then the response can come from
The text was updated successfully, but these errors were encountered: