Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds in a way to add settings for the MLContext. #7273

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Adds in a way to add settings for the MLContext. #7273

merged 4 commits into from
Oct 22, 2024

Conversation

michaelgsharp
Copy link
Member

Adds in a way to add settings for the MLContext. This will allow us to add runtime options for things like OnnxRuntime and LightGBM, or additional advanced options we haven't exposed previously.

@michaelgsharp michaelgsharp marked this pull request as ready for review October 21, 2024 17:10
tarekgh
tarekgh approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couplle of questions. LGTM.

@build-analysis build-analysis bot mentioned this pull request Oct 21, 2024
Open
3 tasks
This was referenced Oct 22, 2024
Open
Open
@codecov Codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.43478% with 34 lines in your changes missing coverage. Please review.

Project coverage is 68.81%. Comparing base (f385b06) to head (c0f7906).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/Microsoft.ML.OnnxTransformer/OnnxUtils.cs 31.57% 23 Missing and 3 partials ⚠️
...Microsoft.ML.OnnxTransformer/OnnxSessionOptions.cs 91.11% 2 Missing and 2 partials ⚠️
src/Microsoft.ML.Data/MLContext.cs 40.00% 3 Missing ⚠️
...osoft.ML.OnnxTransformerTest/OnnxTransformTests.cs 96.15% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7273   +/-   ##
=======================================
  Coverage   68.80%   68.81%           
=======================================
  Files        1461     1462    +1     
  Lines      272400   272497   +97     
  Branches    28176    28190   +14     
=======================================
+ Hits       187436   187508   +72     
- Misses      77729    77749   +20     
- Partials     7235     7240    +5
Flag Coverage Δ
Debug 68.81% <70.43%> (+<0.01%) ⬆️
production 63.30% <62.92%> (+<0.01%) ⬆️
test 89.08% <96.15%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Microsoft.ML.Core/Data/IHostEnvironment.cs 97.56% <ø> (ø)
src/Microsoft.ML.OnnxTransformer/OnnxTransform.cs 87.93% <100.00%> (+0.57%) ⬆️
...osoft.ML.OnnxTransformerTest/OnnxTransformTests.cs 95.56% <96.15%> (+0.01%) ⬆️
src/Microsoft.ML.Data/MLContext.cs 85.71% <40.00%> (-3.95%) ⬇️
...Microsoft.ML.OnnxTransformer/OnnxSessionOptions.cs 91.11% <91.11%> (ø)
src/Microsoft.ML.OnnxTransformer/OnnxUtils.cs 79.56% <31.57%> (-5.26%) ⬇️

... and 5 files with indirect coverage changes

@michaelgsharp
Copy link
Member Author

merging on red as the failure is a known failure that has been fixed already.

@michaelgsharp michaelgsharp merged commit a7a6d88 into dotnet:main Oct 22, 2024
21 of 25 checks passed
@michaelgsharp michaelgsharp deleted the context-settings branch October 22, 2024 22:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

Assignees

@michaelgsharp michaelgsharp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelgsharp @tarekgh