-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arcade linux build #5423
arcade linux build #5423
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,14 +11,14 @@ | |
|
||
<ItemGroup> | ||
<ModelFiles Include="$(ModelPlacementDir)\AlexNetPrepOnnx\AlexNetPreprocess.onnx" | ||
Url="https://aka.ms/mlnet-resources/image/AlexNetPrepOnnx/AlexNetPreprocess.onnx " | ||
Url="https://aka.ms/mlnet-resources/image/AlexNetPrepOnnx/AlexNetPreprocess.onnx" | ||
DestinationFile="$(ModelPlacementDir)\AlexNetPrepOnnx\AlexNetPreprocess.onnx" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was the space causing a problem in Linux only? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I haven't try on mac but this cause download failure on Linux not on Windows. In reply to: 501872554 [](ancestors = 501872554) |
||
DestinationDir="$(ModelPlacementDir)\AlexNetPrepOnnx" /> | ||
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<ModelFiles Include="$(ModelPlacementDir)\ResNetPrepOnnx\ResNetPreprocess.onnx" | ||
Url="https://aka.ms/mlnet-resources/image/ResNetPrepOnnx/ResNetPreprocess.onnx " | ||
Url="https://aka.ms/mlnet-resources/image/ResNetPrepOnnx/ResNetPreprocess.onnx" | ||
DestinationFile="$(ModelPlacementDir)\ResNetPrepOnnx\ResNetPreprocess.onnx" | ||
DestinationDir="$(ModelPlacementDir)\ResNetPrepOnnx" /> | ||
</ItemGroup> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please explain why this was necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, when I test on WSL and docker, I got permission error to run eng/common/build.sh, not sure if that will also happen on CI so I add it anyway.
In reply to: 501871675 [](ancestors = 501871675)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But is this still necessary if you run this once from a linux environment and check the updated file in?
Since the rest of Arcade doesn't have this, I am wondering if you just need to do it only once.
Also, why did we need to replace run.sh line with a direct call to eng/common/build.sh?
In reply to: 501875979 [](ancestors = 501875979,501871675)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right. Seems git will also track file execute permission and we can check in the file permission change. At first I'm not able to see any change in file content in eng/common/build.sh after change this file's execute permission so I undo the change, I just tried "git diff" and it shows the permission change like below:
diff --git a/eng/common/build.sh b/eng/common/build.sh
old mode 100644
new mode 100755
run.sh is using the old build tools to build the project so I replaced with eng/common/build.sh which will build ML.NET with arcade just like what you did for windows build.
In reply to: 501886537 [](ancestors = 501886537,501875979,501871675)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If run.sh is pointing to the old build tools, can we delete it? (And run.cmd?)
In reply to: 501910887 [](ancestors = 501910887,501886537,501875979,501871675)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there are lots of build related files we can delete from old build tools. I'm thinking we can do a clean up at the end of our arcade work if case we need something or reference something from old build tools.
In reply to: 501919713 [](ancestors = 501919713,501910887,501886537,501875979,501871675)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let us clean up as we along.
In reply to: 501935956 [](ancestors = 501935956,501919713,501910887,501886537,501875979,501871675)