fixing scenerio 3 of issue #3995 #4214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaeldekel
reviewed
Sep 15, 2019
| @@ -222,7 +222,8 @@ private protected override void CheckDataValid(IChannel ch, RoleMappedData data) | |||
| $"Label column '{labelCol.Name}' is of type '{labelType.RawType}', but must be Key or Single."); | |||
| } | |||
| // Check group types. | |||
| ch.CheckParam(data.Schema.Group.HasValue, nameof(data), "Need a group column."); | |||
| if(!data.Schema.Group.HasValue) | |||
| throw ch.ExceptValue(nameof(data.Schema.Group), "Group column is missing.") ; | |||
There was a problem hiding this comment.
if (!condition)
throw ...
is the same as doing a check on condition.
#Resolved
There was a problem hiding this comment.
Hi Yael! Checkparam throws an ArgumentOutOfRangeException, I switched to checking manually, so I can throw a different type of exception. There's also a checkvalue function, but it only works for checking classes. #Resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue #3995 scenario 3
I'm waiting to see what can be done about scenario 1(desired behavior not decided yet) and 2( can't replicate). Scenario 4 is not part of our code base.
In this commit, I have made the error comment more clear and switched the exception from an System.ArgumentOutOfRangeException to System.ArgumentNullException. ArgumentOutOfRangeException are reserved for signaling bad function parameters and thus doesn't make sense to use for signaling a missing column value.
So we can do the best job, please check:
Fixes #nnnnin your description to cause GitHub to automatically close the issue(s) when your PR is merged.