Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internalize LpNorm column options. #3078

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Internalize LpNorm column options. #3078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Microsoft.ML.Transforms/GcnTransform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ private static VersionInfo GetVersionInfo()
/// <summary>
/// The objects describing how the transformation is applied on the input data.
/// </summary>
public IReadOnlyCollection<LpNormNormalizingEstimatorBase.ColumnOptionsBase> Columns => _columns.AsReadOnly();
internal IReadOnlyCollection<LpNormNormalizingEstimatorBase.ColumnOptionsBase> Columns => _columns.AsReadOnly();
private readonly LpNormNormalizingEstimatorBase.ColumnOptionsBase[] _columns;

private static (string outputColumnName, string inputColumnName)[] GetColumnPairs(LpNormNormalizingEstimatorBase.ColumnOptionsBase[] columns)
Expand Down Expand Up @@ -671,7 +671,7 @@ public enum NormFunction : byte
/// <summary>
/// Describes base class for one column pair.
/// </summary>
public abstract class ColumnOptionsBase
internal abstract class ColumnOptionsBase
{
/// <summary>
/// Name of the column resulting from the transformation of <see cref="InputColumnName"/>.
Expand Down Expand Up @@ -812,7 +812,7 @@ public sealed class LpNormNormalizingEstimator : LpNormNormalizingEstimatorBase
/// <summary>
/// Describes how the transformer handles one column pair.
/// </summary>
public sealed class ColumnOptions : ColumnOptionsBase
internal sealed class ColumnOptions : ColumnOptionsBase
{
/// <summary>
/// Describes how the transformer handles one column pair.
Expand Down Expand Up @@ -868,7 +868,7 @@ public sealed class GlobalContrastNormalizingEstimator : LpNormNormalizingEstima
/// <summary>
/// Describes how the transformer handles one Gcn column pair.
/// </summary>
public sealed class ColumnOptions : ColumnOptionsBase
internal sealed class ColumnOptions : ColumnOptionsBase
{
/// <summary>
/// Describes how the transformer handles one Gcn column pair.
Expand Down