Creation of components through MLContext, internalization, and renaming #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanidzo4ka
reviewed
Feb 12, 2019
| @@ -197,7 +197,7 @@ public sealed class CustomMappingEstimator<TSrc, TDst> : TrivialEstimator<Custom | |||
| /// <param name="contractName">The contract name, used by ML.NET for loading the model. If <c>null</c> is specified, such a trained model would not be save-able.</param> | |||
| /// <param name="inputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TSrc"/> and input data.</param> | |||
| /// <param name="outputSchemaDefinition">Additional parameters for schema mapping between <typeparamref name="TDst"/> and output data.</param> | |||
| public CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName, | |||
| internal CustomMappingEstimator(IHostEnvironment env, Action<TSrc, TDst> mapAction, string contractName, | |||
There was a problem hiding this comment.
CustomMappingEstimator [](start = 17, length = 22)
We don't have any samples/ tests with it at all? #Resolved
There was a problem hiding this comment.
abgoswam
reviewed
Feb 12, 2019
abgoswam
reviewed
Feb 12, 2019
abgoswam
reviewed
Feb 12, 2019
artidoro
force-pushed
the
estimatortransformer
branch
from
35e93ef
to
80bde05
Compare
abgoswam
reviewed
Feb 13, 2019
docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/RandomTrainerSample.cs
Show resolved
Hide resolved
abgoswam
reviewed
Feb 13, 2019
docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/PriorTrainerSample.cs
Show resolved
Hide resolved
artidoro
force-pushed
the
estimatortransformer
branch
from
ff4cd97
to
205958c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2510 +/- ##
==========================================
+ Coverage 71.25% 71.25% +<.01%
==========================================
Files 797 797
Lines 141271 141280 +9
Branches 16115 16115
==========================================
+ Hits 100663 100671 +8
- Misses 36148 36149 +1
Partials 4460 4460
|
Ivanidzo4ka
reviewed
Feb 13, 2019
|
|
||
| namespace Microsoft.ML.Samples.Dynamic | ||
| { | ||
| public class RandomTrainerSample |
There was a problem hiding this comment.
RandomTrainerSample [](start = 17, length = 19)
Zeeshan A, Shahab and me have PRs where we create BinaryClassification folder.
Any chance you can move this two to that folder?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1798, #1758
DnnImageFeaturizerEstimator,PriorTrainer, andRandomTrainer. This required to add catalog extensions for these three trainers. Internalizing these constructor closes issue Creation of components through MLContext: advanced options and other feedback #1798.ArgumentstoOptionswhich closes issue Arguments class should be made internal when possible #1758.ITransformersandIEstimators.Optionsclass in TensorflowTransform to the estimator.