-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the parameters description in the summary as described in the issue 2177 #2432
Changes from 1 commit
6e1b08e
6bf8a17
9e1b8b4
726a5e3
1103cda
1a9ebb0
671ca11
c94be09
245b336
d5ee839
17e2954
9dda72d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,9 +17,9 @@ public static class TreeExtensions | |
/// Predict a target using a decision tree regression model trained with the <see cref="FastTreeRegressionTrainer"/>. | ||
/// </summary> | ||
/// <param name="catalog">The <see cref="RegressionCatalog"/>.</param> | ||
/// <param name="labelColumn">The label column.</param> | ||
/// <param name="featureColumn">The feature column.</param> | ||
/// <param name="weights">The optional weights column.</param> | ||
/// <param name="labelColumn">The name of the label column.</param> | ||
/// <param name="featureColumn">The name of the feature column.</param> | ||
/// <param name="weights">The name of the optional weights column.</param> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
can you update this one as well, otherwise build is not working #Closed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry I meant in whole file. We have strict rules to match parameters names in xml documentation In reply to: 255319474 [](ancestors = 255319474) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should be ok now |
||
/// <param name="numTrees">Total number of decision trees to create in the ensemble.</param> | ||
/// <param name="numLeaves">The maximum number of leaves per decision tree.</param> | ||
/// <param name="minDatapointsInLeaves">The minimal number of datapoints allowed in a leaf of a regression tree, out of the subsampled data.</param> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so weightsColumnName, labelColumnName, featureColumnName.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change the name of the parameters too or is a different issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not hard for you.
This weights is actually
weightsColumn
or
weightColumn
@sfilipi why we use singular for feature column and plural for weight column?
In reply to: 254624678 [](ancestors = 254624678)