Add a sample for Permutation Feature Importance #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogancarr
force-pushed
the
1723_PFI_Documentation
branch
from
4c82069
to
e1a5d3a
Compare
rogancarr
changed the title
rogancarr
changed the title
sfilipi
reviewed
Nov 27, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance.cs
Show resolved
Hide resolved
sfilipi
reviewed
Nov 27, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance.cs
Outdated
Show resolved
Hide resolved
sfilipi
reviewed
Nov 27, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance.cs
Outdated
Show resolved
Hide resolved
sfilipi
approved these changes
Nov 27, 2018
wschin
reviewed
Nov 27, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance.cs
Outdated
Show resolved
Hide resolved
Co-Authored-By: rogancarr <[email protected]>
wschin
reviewed
Nov 28, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance.cs
Show resolved
Hide resolved
wschin
reviewed
Nov 28, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance.cs
Outdated
Show resolved
Hide resolved
wschin
reviewed
Nov 28, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance.cs
Outdated
Show resolved
Hide resolved
wschin
reviewed
Nov 28, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance.cs
Outdated
Show resolved
Hide resolved
wschin
reviewed
Nov 28, 2018
| var weights = GetLinearModelWeights(linearPredictor.Model); | ||
|
|
||
| // Compute the permutation metrics using the properly-featurized data. | ||
| var transformedData = fitPipeline.Transform(data); |
There was a problem hiding this comment.
It implies that feature name can't not be identical to predicted label/score name produced by the linear model. Could you make a note here?
There was a problem hiding this comment.
The PFI calculation actually does its own scoring, and should do this. I actually just do this to produce the Features column.
added 2 commits
November 27, 2018 16:29
wschin
approved these changes
Nov 28, 2018
wschin
reviewed
Nov 28, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance.cs
Show resolved
Hide resolved
wschin
reviewed
Nov 28, 2018
docs/samples/Microsoft.ML.Samples/Dynamic/PermutationFeatureImportance.cs
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a sample for using
PermutationFeatureImportance.The sample looks at the feature importances for a linear model predicting housing prices with the
HousingRegressiondataset and shows how to interpret the output ofPermutationFeatureImportanceas a measure of global feature importance.Fixes #1723