more transform => transformer renaming #1590
Conversation
nit: unrelated, but should be internal or private same for all other signature methods. #Pending Refers to: src/Microsoft.ML.Transforms/NAReplaceTransform.cs:464 in ca16fa1. [](commit_id = ca16fa1, deletion_comment = False) |
| @@ -249,7 +249,7 @@ private string GetBuildPrefix() | |||
| #endif | |||
| } | |||
|
|
|||
| [Fact] | |||
| [Fact(Skip = "Execute this test if you want to regenerate the core_manifest and core_ep_list files")] | |||
There was a problem hiding this comment.
Skip = "Execute this test if you want to regenerate the core_manifest and core_ep_list files") [](start = 14, length = 94)
https://media.tenor.com/images/f6f91f0f5bd4d733e1fb9dfee1c37580/tenor.gif #Resolved
There was a problem hiding this comment.
| [assembly: LoadableClass(NADropTransform.Summary, typeof(NADropTransform), null, typeof(SignatureLoadDataTransform), | ||
| NADropTransform.FriendlyName, NADropTransform.LoaderSignature)] | ||
| [assembly: LoadableClass(MissingValueDroppingTransformer.Summary, typeof(MissingValueDroppingTransformer), null, typeof(SignatureLoadDataTransform), | ||
| MissingValueDroppingTransformer.FriendlyName, MissingValueDroppingTransformer.LoaderSignature)] | ||
|
|
||
| namespace Microsoft.ML.Runtime.Data | ||
| { | ||
| /// <include file='doc.xml' path='doc/members/member[@name="NADrop"]'/> |
There was a problem hiding this comment.
NADrop [](start = 64, length = 6)
nit: these names can potentially backfire, but I'm don't know what our plans for them, and documentation in general. #Pending
There was a problem hiding this comment.
documentation needs to be scrubbed from the term transform, and adapted to transformer/estimator. Didn't want to bundle those changes together with the renames, because the renames have to finish on this release.
In reply to: 232742005 [](ancestors = 232742005)
Agree. I will leave it since that can be a bug/change on its own, and it is currently unrelated to this bug. In reply to: 437957613 [](ancestors = 437957613) Refers to: src/Microsoft.ML.Transforms/NAReplaceTransform.cs:464 in ca16fa1. [](commit_id = ca16fa1, deletion_comment = False) |
ghost
locked as resolved and limited conversation to collaborators
Fixes part of #1318