Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding another handful transform's extensions #1494

Merged
merged 4 commits into from
Nov 1, 2018

Conversation

sfilipi
Copy link
Member

@sfilipi sfilipi commented Nov 1, 2018

Part of #1318

Adds more transform extensions in the catalog.

Copy link

@shmoradims shmoradims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sfilipi sfilipi added the API Issues pertaining the friendly API label Nov 1, 2018
@sfilipi sfilipi self-assigned this Nov 1, 2018
@sfilipi sfilipi requested a review from singlis November 1, 2018 18:18
public static class PcaCatalog
{

/// <summary>Initializes a new instance of <see cref="PrincipalComponentAnalysisEstimator"/>.</summary>
Copy link
Member

@singlis singlis Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[](start = 101, length = 10)

Not needed. #Pending

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? All the examples close the tag:

https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/xmldoc/xml-documentation-comments


In reply to: 230154186 [](ancestors = 230154186)

Copy link
Member

@singlis singlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sfilipi sfilipi merged commit d68388a into dotnet:master Nov 1, 2018
sfilipi added a commit to sfilipi/machinelearning-1 that referenced this pull request Nov 1, 2018
@sfilipi sfilipi deleted the evenMoreXtensions branch November 3, 2018 06:50
@ghost ghost locked as resolved and limited conversation to collaborators Mar 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues pertaining the friendly API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants