Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename GroupId column to RowGroup #2660

Closed
Ivanidzo4ka opened this issue Feb 20, 2019 · 2 comments
Closed

Rename GroupId column to RowGroup #2660

Ivanidzo4ka opened this issue Feb 20, 2019 · 2 comments
Assignees
@abgoswam
Labels
API Issues pertaining the friendly API
Milestone
0219

Comments

@Ivanidzo4ka
Copy link
Contributor

machinelearning/src/Microsoft.ML.LightGBM/LightGbmCatalog.cs

Line 127 in 4a71e50

/// <param name="groupIdColumn">The groupId column.</param>

Conversation can be found here:
#2536
@Ivanidzo4ka Ivanidzo4ka added the API Issues pertaining the friendly API label Feb 20, 2019
@abgoswam abgoswam mentioned this issue Feb 20, 2019
Closed
@abgoswam
Copy link
Member

For the sake of consistency (as mentioned in issue #2177 ) should we call it

  • rowGroupColumnName

@abgoswam abgoswam self-assigned this Feb 20, 2019
This was referenced Feb 20, 2019
Merged
Closed
@shauheen shauheen added this to the 0219 milestone Feb 21, 2019
@abgoswam
Copy link
Member

Fixed by PR #2665

@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@abgoswam abgoswam

Labels
API Issues pertaining the friendly API
Projects
None yet
Milestone
0219
Development

No branches or pull requests
3 participants
@Ivanidzo4ka @shauheen @abgoswam