Produce LLVM packages for Apple Silicon #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directhex
commented
Mar 4, 2021
•
directhex
commented
steveisok
approved these changes
Mar 5, 2021
akoeplinger
reviewed
Mar 5, 2021
| @@ -12,7 +12,8 @@ | |||
|
|
|||
| <!-- Distro rid is passed as runtimeos-arch--> | |||
| <_parseDistroRid>$(__DistroRid)</_parseDistroRid> | |||
| <_parseDistroRid Condition="'$(_parseDistroRid)' == '' and '$(__BuildOS)' == 'OSX'">osx.10.12-x64</_parseDistroRid> | |||
| <_parseDistroRid Condition="'$(_parseDistroRid)' == '' and '$(__BuildOS)' == 'OSX' and '$(Platform)' == 'arm64'">osx.11.0-arm64</_parseDistroRid> | |||
| <_parseDistroRid Condition="'$(_parseDistroRid)' == '' and '$(__BuildOS)' == 'OSX' and '$(Platform)' != 'arm64'">osx.10.12-x64</_parseDistroRid> | |||
There was a problem hiding this comment.
@directhex given we use CMAKE_OSX_DEPLOYMENT_TARGET=10.13 we should probably bump the RID to osx.10.13-x64? or actually why do we use a version-specific RID at all rather than osx-x64 like we do elsewhere?
There was a problem hiding this comment.
That is an EXCELLENT QUESTION for past Jo, because present day Jo is experiencing what a pain in the ass it is to consume it this way, given how llvm-init.proj is written
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.