Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target net6.0 for linker #2202

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Target net6.0 for linker #2202

merged 2 commits into from
Aug 11, 2021

Conversation

vitek-karas
Copy link
Member

Fixes #2118

@vitek-karas vitek-karas added this to the .NET 6.0 milestone Aug 10, 2021
@vitek-karas vitek-karas requested a review from sbomer August 10, 2021 20:15
sbomer
sbomer approved these changes Aug 10, 2021
View reviewed changes
src/ILLink.Tasks/ILLink.Tasks.csproj Outdated
@@ -2,7 +2,7 @@
<PropertyGroup>
<!-- Keep these in sync with _ILLinkTasksTFM in Sdk.props. -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth updating this comment.

agocke
agocke approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this change anything since the SDK usually forces everyone to net6.0 in publishing anyway?

@vitek-karas
Copy link
Member Author

Does this change anything since the SDK usually forces everyone to net6.0 in publishing anyway?

Not really - the only scenario affected is if you run linker directly. Nobody does that - except us when debugging the linker.

@vitek-karas vitek-karas merged commit 7bf5cd4 into dotnet:main Aug 11, 2021
@vitek-karas vitek-karas deleted the Target60 branch August 11, 2021 10:30
@lewing
Copy link
Member

lewing commented Aug 11, 2021

This seems to be causing issues dotnet/sdk#19655 and dotnet/runtime#57203

@vitek-karas
Copy link
Member Author

Working on it...

@mateoatr
Copy link
Contributor

I'm taking a look. This appears to be caused by the analyzer not taking into account the SuppressTrimAnalysisWarnings, ILLinkWarningLevel properties.

@mateoatr
Copy link
Contributor

I'm taking a look. This appears to be caused by the analyzer not taking into account the SuppressTrimAnalysisWarnings, ILLinkWarningLevel properties.

Ok, the error was about wrong path. Thanks for clarification @vitek-karas.

agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
@vitek-karas
Target net6.0 for linker (dotnet/linker#2202)
7819670 
Commit migrated from dotnet/linker@7bf5cd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbomer sbomer sbomer approved these changes

@agocke agocke agocke approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees
No one assigned
Labels
area-Build
Projects
None yet
Milestone
6.0.x
Development

Successfully merging this pull request may close these issues.

Upgrade linker product projects to target net6.0
5 participants
@vitek-karas @lewing @mateoatr @agocke @sbomer