Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd myget-legacy feed #359

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

jakobbotsch
Copy link
Member

We are still depending on an ancient version of System.Commandline, 0.1.0-e170320-1, which we get from this feed. Readd it to unblock things, otherwise all our SPMI jobs fail in dotnet/runtime when they try to build jitutils.

We are still depending on an ancient version of System.Commandline,
0.1.0-e170320-1, which we get from this feed. Readd it to unblock
things.
@jakobbotsch
Copy link
Member Author

cc @BruceForstall

@am11 feel free to take it upon yourself to upgrade the problematic projects to the more recent version of System.CommandLine 😄

Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the order here matter? It was previously listed first.

@jakobbotsch
Copy link
Member Author

Does the order here matter? It was previously listed first.

It doesn't seem to, I think because of the exact version we specify that is only found in this feed.

@am11 feel free to take it upon yourself to upgrade the problematic projects to the more recent version of System.CommandLine 😄

@BruceForstall pointed out that this is #193 and that the System.CommandLine we are relying on now might be quite different than what is called System.CommandLine today.

@jakobbotsch jakobbotsch merged commit 2757446 into dotnet:main Oct 26, 2022
@jakobbotsch jakobbotsch deleted the readd-nuget-feed branch October 26, 2022 19:08
jakobbotsch added a commit to jakobbotsch/jitutils that referenced this pull request Oct 26, 2022
@am11
Copy link
Member

am11 commented Oct 27, 2022

Thanks! I think I had older versions cached, clearing the cache revealed the error. 😁

I will try to migrate tools to System.CommandLine v2. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants