Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTx: Invert Data and direction position when setting up outputs for SPI mode #2362

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

ProtectedVariable
Copy link
Contributor

@ProtectedVariable ProtectedVariable commented Nov 14, 2024

The opcode specification says that data comes before direction. The current code prevents the clock pin from outputting the clock signal.

I've tested with a FT232H and the previous version made PIN D0 output a constant 3.3v signal. With the changes it outputs the clock signal

Microsoft Reviewers: Open in CodeFlow

The opcode specification says that data comes before direction. The current code prevents the clock pin from outputting the clock signal
@dotnet-policy-service dotnet-policy-service bot added the area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio label Nov 14, 2024
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@Ellerbach
Copy link
Member

@pgrawehr the Arduino build is failing again. Does that make sense to make this pipeline manual? So, we trigger it only when there is something related to it? In that case, it's not at all supported on that specific platform.

@Ellerbach
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pgrawehr
Copy link
Contributor

/azp run dotnet.iot

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pgrawehr pgrawehr merged commit 9c6b628 into dotnet:main Dec 27, 2024
9 of 10 checks passed
@pgrawehr
Copy link
Contributor

@ProtectedVariable Thanks for the fix!

@ProtectedVariable ProtectedVariable deleted the patch-1 branch December 30, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-device-bindings Device Bindings for audio, sensor, motor, and display hardware that can used with System.Device.Gpio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants