#2346 decode ATS if present (ISO 14443-4 card) #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
area-device-bindings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PN532 will return the ATS for a ISO 14443-4 card, but the existing logic in
PN532.TryDecode106kbpsTypeAdoes not decode it. As noted in issue #2346, the length check has the wrong sense. Also, as per ISO 14443-4 (section 5.2) the ATS includes the length byte, the value of which includes itself.Tested with an ISO 14443-4 card - the ATS is decoded.
Microsoft Reviewers: Open in CodeFlow