Minor cleanup

dotnet · Aug 22, 2024 · 524d67e · 524d67e
1 parent 5026563
commit 524d67e
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/src/Iot.Device.Bindings/CompatibilitySuppressions.xml b/src/Iot.Device.Bindings/CompatibilitySuppressions.xml
@@ -78,6 +78,13 @@
     <Right>lib/net6.0/Iot.Device.Bindings.dll</Right>
     <IsBaselineSuppression>true</IsBaselineSuppression>
   </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0002</DiagnosticId>
+    <Target>F:Iot.Device.Ssd13xx.Ssd13xx._i2cDevice</Target>
+    <Left>lib/net6.0/Iot.Device.Bindings.dll</Left>
+    <Right>lib/net6.0/Iot.Device.Bindings.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
   <Suppression>
     <DiagnosticId>CP0002</DiagnosticId>
     <Target>M:Iot.Device.Axp192.Axp192.SetGPIO0(Iot.Device.Axp192.Gpio0Behavior,System.Byte)</Target>
@@ -225,6 +232,13 @@
     <Right>lib/netstandard2.0/Iot.Device.Bindings.dll</Right>
     <IsBaselineSuppression>true</IsBaselineSuppression>
   </Suppression>
+  <Suppression>
+    <DiagnosticId>CP0002</DiagnosticId>
+    <Target>F:Iot.Device.Ssd13xx.Ssd13xx._i2cDevice</Target>
+    <Left>lib/netstandard2.0/Iot.Device.Bindings.dll</Left>
+    <Right>lib/netstandard2.0/Iot.Device.Bindings.dll</Right>
+    <IsBaselineSuppression>true</IsBaselineSuppression>
+  </Suppression>
   <Suppression>
     <DiagnosticId>CP0002</DiagnosticId>
     <Target>M:Iot.Device.Axp192.Axp192.SetGPIO0(Iot.Device.Axp192.Gpio0Behavior,System.Byte)</Target>

diff --git a/src/devices/Ssd13xx/Ssd1309.cs b/src/devices/Ssd13xx/Ssd1309.cs
@@ -174,7 +174,8 @@ protected override void SetStartAddress()
         }
 
         /// <summary>
-        /// Reset device by cycling RST pin to LOW and resting at HIGH
+        /// Reset device by cycling RST pin to LOW and resting at HIGH.
+        /// This will not re-initialize the device.
         /// </summary>
         protected virtual void Reset()
         {

diff --git a/src/devices/Ssd13xx/Ssd13xx.cs b/src/devices/Ssd13xx/Ssd13xx.cs
@@ -24,12 +24,12 @@ public abstract class Ssd13xx : GraphicDisplay
         /// <summary>
         /// Underlying I2C device
         /// </summary>
-        internal I2cDevice? I2cDevice { get; set; }
+        protected I2cDevice? I2cDevice { get; set; }
 
         /// <summary>
         /// Underlying SPI device
         /// </summary>
-        internal SpiDevice? SpiDevice { get; set; }
+        protected SpiDevice? SpiDevice { get; set; }
 
         /// <summary>
         /// Constructs instance of Ssd13xx using an I2C device