extract api to configure aspnet hosting to expose .NET Interactive api #802

colombod · 2020-09-29T11:41:56Z

No description provided.

jonsequitur · 2020-10-07T21:08:57Z

src/Microsoft.DotNet.Interactive/JavascriptUtilities.cs

+{
+    public static class JavascriptUtilities
+    {
+        public static string EnsureRequireJs(Uri requireJsUri = null, string callBackName = null)


This name and return type could be clearer. Ensure* usually means ensure some thing has been done, and signals idempotency. This returns a string.

What's it really doing?

that returns the javascript code snippet that checks and pull in if needed the requirejs library

jonsequitur · 2020-10-07T21:14:55Z

src/Microsoft.DotNet.Interactive.Http/FileProvider.cs

 {
    public class FileProvider : IFileProvider, IDisposable
    {
        private readonly EmbeddedFileProvider _root;
        private readonly IDisposable _eventSubscription;
        private readonly ConcurrentDictionary<string, EmbeddedFileProvider> _providers = new ConcurrentDictionary<string, EmbeddedFileProvider>();

-        public FileProvider(Kernel kernel)
+        public FileProvider(Kernel kernel, Assembly rootProvider)


Suggested change

public FileProvider(Kernel kernel, Assembly rootProvider)

public FileProvider(Kernel kernel, Assembly rootProviderAssembly)

sounds good

jonsequitur · 2020-10-07T21:18:18Z

src/Microsoft.DotNet.Interactive.Http/AspNetExtensions.cs

+                });
+            return builder;
+        }
+        public static IServiceCollection AddDotnetInteractive(this IServiceCollection services)


Maybe the naming should also include the fact that this is adding HTTP-specific functionality?

jonsequitur · 2020-10-07T21:18:37Z

src/Microsoft.DotNet.Interactive.Http/AspNetExtensions.cs

+
+            return services;
+        }
+        public static IApplicationBuilder UseDotNetInteractive<T>(this IApplicationBuilder app, T kernel, Assembly staticResourceRoot, HttpProbingSettings httpProbingSettings, HttpPort httpPort) where T : Kernel


src/Microsoft.DotNet.Interactive.Http/AspNetExtensions.cs

jonsequitur · 2020-10-07T21:23:34Z

src/dotnet-interactive/CommandLine/CommandLineParser.cs

@@ -305,14 +300,8 @@ Command HttpServer()
                httpCommand.Handler = CommandHandler.Create<StartupOptions, KernelHttpOptions, IConsole, InvocationContext>(


I just noticed that KernelHttpOptions has nothing to do with HTTP. Does it need to exist and why would it be different from the already-existing DefaultKernel concept?

jonsequitur · 2020-10-12T16:40:24Z

docs/javascript-overview.md

+
+Here is an example.
+![image](https://user-images.githubusercontent.com/375556/95768858-e6be3500-0cae-11eb-925c-53d46670bd09.png)


Let's use text rather than images to document APIs. This will be hard to search for otherwise.

removed image and made test example that users can actually use and try

jonsequitur · 2020-10-12T16:41:22Z

docs/javascript-overview.md

+Here is an example.
+![image](https://user-images.githubusercontent.com/375556/95768858-e6be3500-0cae-11eb-925c-53d46670bd09.png)
+The `interactive.configureRequire` takes as input a [requirejs configuration object](https://www.tutorialspoint.com/requirejs/requirejs_configuration.htm) and returns a function that you can now use to load the dependecies.


Let's add a simple, working code sample.

jonsequitur · 2020-10-12T16:44:11Z

src/dotnet-interactive/CommandLine/CommandLineParser.cs

@@ -529,7 +515,7 @@ static HttpPortRange ParsePortRangeOption(ArgumentResult result)
            SetUpFormatters(frontendEnvironment, startupOptions, TimeSpan.FromSeconds(15));

            kernel.DefaultKernelName = defaultKernelName;
-
+            services.AddKernel(kernel);


Doing this here seems to blur some boundaries. I would expect the caller to this method to handle registration, and for this method to be non-side-affecting.

that part of code has always been like that as the kernel is created as side effect while executing the command line parser. the caller is passing in the ServiceCollection and merging it with the one used during asp.net configuration

docs/javascript-overview.md

jonsequitur · 2020-10-12T20:12:44Z

docs/javascript-overview.md

+});
+```
+
+Now you can require the module and use it. Using `#!html` to inject an `svg` element and then `#!js` to load the `d3.js` library and append a circle to the dom


Suggested change

Now you can require the module and use it. Using `#!html` to inject an `svg` element and then `#!js` to load the `d3.js` library and append a circle to the dom

Now you can require the module and use it. You can use the `#!html` magic command to inject an SVG element and then the `#!js` magic command to load the D3.js library and append a circle.

jonsequitur · 2020-10-12T20:13:27Z

docs/javascript-overview.md

+
+#!js
+#!html
+<svg id="renderTarget" width=300 height=300></svg>


You have an extra #!js here and the renderTarget is being added twice.

jonsequitur · 2020-10-12T20:13:39Z

docs/javascript-overview.md

+
+```
+#!html
+<sgv id"renderTarget"></svg>


Suggested change

<sgv id"renderTarget"></svg>

<svg id"renderTarget"></svg>

remove unused js function and rename helper to condifugreRequire for general require and configureRequireFromExtension for the require function taht will load static content form interactive extensions

…tJsLoader

Co-authored-by: Jon Sequeira <[email protected]>

colombod requested a review from jonsequitur September 29, 2020 15:56

colombod force-pushed the http_server branch from c3082a5 to da6a981 Compare September 29, 2020 15:57

colombod changed the title ~~[WIP] extract to register with aspnet hosting~~ extract to register with aspnet hosting Sep 29, 2020

colombod requested a review from brettfo September 29, 2020 19:58

colombod force-pushed the http_server branch from 3ab0cb6 to 5ba56e8 Compare September 30, 2020 12:11

colombod changed the title ~~extract to register with aspnet hosting~~ extract api to configure aspnet hosting to expose .NET Interactive api Sep 30, 2020

colombod force-pushed the http_server branch 3 times, most recently from 3aa6fbc to 4c5fae0 Compare September 30, 2020 16:37

colombod mentioned this pull request Sep 30, 2020

[QUESTION]: Can .NET interactive be embedded in a Web Application? #800

Closed

colombod force-pushed the http_server branch 2 times, most recently from 61bed59 to e9210dc Compare October 6, 2020 01:15

jonsequitur reviewed Oct 7, 2020

View reviewed changes

src/Microsoft.DotNet.Interactive.Http/AspNetExtensions.cs Outdated Show resolved Hide resolved

jonsequitur reviewed Oct 7, 2020

View reviewed changes

src/Microsoft.DotNet.Interactive.Http/AspNetExtensions.cs Outdated Show resolved Hide resolved

jonsequitur reviewed Oct 7, 2020

View reviewed changes

colombod force-pushed the http_server branch 2 times, most recently from 2887f15 to 11fb909 Compare October 12, 2020 16:25

jonsequitur reviewed Oct 12, 2020

View reviewed changes

docs/javascript-overview.md Outdated Show resolved Hide resolved

jonsequitur reviewed Oct 12, 2020

View reviewed changes

colombod and others added 2 commits October 13, 2020 23:05

tests

da541ea

create project and move logic

c88c59e

colombod and others added 23 commits October 13, 2020 23:05

unused variable

87cacf8

concurrency issue

317ee8c

updated testing packages

9e1590f

fix version

8e913d4

consolidate the code generation for require js loading in hosting page

f4b64d9

refator js helpers

2bca74b

remove unused js function and rename helper to condifugreRequire for general require and configureRequireFromExtension for the require function taht will load static content form interactive extensions

modifiy dotnet-interactive js to expose.configureRequire intest of ge…

a778ca7

…tJsLoader

use configureRequireFromExtension

c2fab28

align vscode extension bootstrapping

59c36fe

powershell project

77a8eb6

rename rootProvider to rootProviderAssembly

c71a268

Update src/Microsoft.DotNet.Interactive.Http/AspNetExtensions.cs

4c3ec02

Co-authored-by: Jon Sequeira <[email protected]>

Update src/Microsoft.DotNet.Interactive.Http/AspNetExtensions.cs

7fd6092

Co-authored-by: Jon Sequeira <[email protected]>

renamed code generator

a8b403e

pr feedback part 1

07a01cf

make Microsoft.DotNet.Interactive.Http packable

04948c1

update sample and fix bug

6ab32bf

consolidate versions

ba52b56

add require example to docs

ba76582

update the documentation with a code example instead of the image

b960bc3

remove side effects from CreateKernel function

5174ec8

Update docs/javascript-overview.md

7af8be0

Co-authored-by: Jon Sequeira <[email protected]>

fix errors in docs

a14a7fc

colombod force-pushed the http_server branch from 6cbb325 to a14a7fc Compare October 13, 2020 22:07

colombod and others added 2 commits October 13, 2020 23:19

better package description

b79d32b

improved documentation on requirejs functionality

a1f03f7

colombod requested a review from jonsequitur October 14, 2020 22:00

jonsequitur approved these changes Oct 14, 2020

View reviewed changes

colombod merged commit 3e46eb1 into dotnet:main Oct 14, 2020

colombod deleted the http_server branch October 14, 2020 22:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

extract api to configure aspnet hosting to expose .NET Interactive api #802

extract api to configure aspnet hosting to expose .NET Interactive api #802

colombod commented Sep 29, 2020

jonsequitur Oct 7, 2020

colombod Oct 7, 2020

jonsequitur Oct 7, 2020

colombod Oct 7, 2020

jonsequitur Oct 7, 2020

jonsequitur Oct 7, 2020

jonsequitur Oct 7, 2020

jonsequitur Oct 12, 2020 •

edited

Loading

colombod Oct 12, 2020

jonsequitur Oct 12, 2020

colombod Oct 12, 2020

jonsequitur Oct 12, 2020

colombod Oct 12, 2020

jonsequitur Oct 12, 2020

jonsequitur Oct 12, 2020

colombod Oct 12, 2020

jonsequitur Oct 12, 2020

colombod Oct 12, 2020

	public FileProvider(Kernel kernel, Assembly rootProvider)
	public FileProvider(Kernel kernel, Assembly rootProviderAssembly)

		@@ -305,14 +300,8 @@ Command HttpServer()
		httpCommand.Handler = CommandHandler.Create<StartupOptions, KernelHttpOptions, IConsole, InvocationContext>(


		Here is an example.
		![image](https://user-images.githubusercontent.com/375556/95768858-e6be3500-0cae-11eb-925c-53d46670bd09.png)

	Now you can require the module and use it. Using `#!html` to inject an `svg` element and then `#!js` to load the `d3.js` library and append a circle to the dom
	Now you can require the module and use it. You can use the `#!html` magic command to inject an SVG element and then the `#!js` magic command to load the D3.js library and append a circle.

extract api to configure aspnet hosting to expose .NET Interactive api #802

extract api to configure aspnet hosting to expose .NET Interactive api #802

Conversation

colombod commented Sep 29, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonsequitur Oct 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonsequitur Oct 12, 2020 •

edited

Loading