Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object instance completions #616

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

colombod
Copy link
Member

@colombod colombod commented Jul 3, 2020

Addresses #607

Victory

image

image

@colombod colombod requested review from brettfo and jonsequitur July 3, 2020 23:56
@colombod colombod force-pushed the feature/intellisense_on_instance branch 2 times, most recently from 4ec97af to 0702c77 Compare July 7, 2020 00:43
@colombod colombod changed the title [wip] object instance completions object instance completions Jul 7, 2020
@colombod colombod force-pushed the feature/intellisense_on_instance branch from 5c8c04b to 722334f Compare July 7, 2020 11:23
add test


add previous submission to previous project


clean project


fix duplication


inherit from workspace and apply solution cahnges


finally victory


ensure diagnostic behavior with shadowing variables


revert changes


revert parser


revert parser
@colombod colombod force-pushed the feature/intellisense_on_instance branch from 58912e8 to c01be48 Compare July 7, 2020 11:32
@colombod colombod requested a review from LadyNaggaga July 7, 2020 11:50
Copy link
Contributor

@LadyNaggaga LadyNaggaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colombod colombod mentioned this pull request Jul 7, 2020
14 tasks
@colombod colombod merged commit 27a303d into dotnet:master Jul 7, 2020
@colombod colombod deleted the feature/intellisense_on_instance branch July 7, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants