[WIP] Update Connect WPF Sample? #3724
Draft
+90
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dummy Directory.Build.props to stop propogation of Arcade props which prevents building sample project
jonsequitur
reviewed
Oct 18, 2024
| @@ -123,6 +123,10 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.DotNet.Interactiv | |||
| EndProject | |||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.DotNet.Interactive.Parsing.Tests", "src\Microsoft.DotNet.Interactive.Parsing.Tests\Microsoft.DotNet.Interactive.Parsing.Tests.csproj", "{55138BD7-111A-43A5-BFBB-326606C4C1B5}" | |||
| EndProject | |||
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "samples", "samples", "{49E6C2EA-FE81-47DF-B206-F818669BEFB1}" | |||
There was a problem hiding this comment.
We've been keeping samples out of the solution. Ideally the samples build against NuGet packages, since most people using them won't be building this code.
jonsequitur
reviewed
Oct 18, 2024
| @@ -8,7 +8,9 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.DotNet.Interactive.CSharp" Version="1.0.0-beta.23403.1" /> | |||
| <ProjectReference Include="..\..\src\Microsoft.DotNet.Interactive.CSharp\Microsoft.DotNet.Interactive.CSharp.csproj" /> | |||
There was a problem hiding this comment.
These should be package references and not project references.
jonsequitur
reviewed
Oct 18, 2024
| @@ -59,6 +59,9 @@ | |||
| } | |||
| ], | |||
| "source": [ | |||
| "#i \"nuget:I:\\oss\\dotnetinteractive\\artifacts\\packages\\Debug\\Shipping\"\n", | |||
There was a problem hiding this comment.
Referencing a hard-coded path won't work for most people, and we don't want to expect people to build the solution in any case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #3723 and dependent probably on #3720
This is an initial start for updating the Connect WPF sample:
That's as far as I could get, it seems to connect to the WPF app (maybe) and then stalls out? The connect command just continues to 'run' and ignores the request to stop in the notebook from VS Code (with no output/status).
I'm out-of-my-depth now trying to just update the code as best as I can with the internals of how .NET Interactive works, but figured putting an update together to share what I had as a starting point for others to jump on would be useful.
Thanks!