respond to latest api changes #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colombod
reviewed
Jun 2, 2021
colombod
requested changes
Jun 2, 2021
colombod
approved these changes
Jun 2, 2021
colombod
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More VS Code API changes, the most notable is that the property
NotebookCellOutput.outputshas been renamed toNotebookCellOutput.items. The old property name is still runtime compatible, but we should respond to the changes as soon as possible.N.b., that there are 3 warnings when building the insiders extension:common/vscode/commands.ts:134 - The namespacenotebookwas renamed tonotebooks, but to enable this to build in both stable and insiders, the old name was preserved. This will be runtime compatible for a short while.common/vscode/extension.ts:174 - Samenotebook/notebooksnamespace issue as above.common/vscode/extension.ts:208 -viewTypewas renamed tonotebookType, but like the namespace change mentioned above, the old name will be runtime compatible for a bit.Test notebook script was verified against both stable and insiders.