remove old object table formatters, clean up

dotnet · Feb 4, 2023 · 2fa8996 · 2fa8996
1 parent 5fe4981
commit 2fa8996
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 405 deletions.
diff --git a/...ts/HtmlFormatterTests.Objects_TreeView.cs → ...tting.Tests/HtmlFormatterTests.Objects.cs b/...ts/HtmlFormatterTests.Objects_TreeView.cs → ...tting.Tests/HtmlFormatterTests.Objects.cs
@@ -16,13 +16,8 @@ namespace Microsoft.DotNet.Interactive.Formatting.Tests;
 
 public partial class HtmlFormatterTests
 {
-    public class Objects_TreeView : FormatterTestBase
+    public class Objects : FormatterTestBase
     {
-        public Objects_TreeView()
-        {
-            HtmlFormatter.UseTreeView = true;
-        }
-
         [Fact]
         public void Formatters_are_generated_on_the_fly_for_anonymous_types()
         {

diff --git a/src/Microsoft.DotNet.Interactive.Formatting.Tests/HtmlFormatterTests.Objects_TableView.cs b/src/Microsoft.DotNet.Interactive.Formatting.Tests/HtmlFormatterTests.Objects_TableView.cs
diff --git a/src/Microsoft.DotNet.Interactive.Formatting/HtmlFormatter.cs b/src/Microsoft.DotNet.Interactive.Formatting/HtmlFormatter.cs
@@ -24,17 +24,10 @@ static HtmlFormatter()
 
         void Initialize()
         {
-#if (false) // FIX: delete
-            FormattersForAnyObject = new FormatterMapByType(typeof(HtmlFormatter<>), nameof(HtmlFormatter<object>.CreateTableFormatterForAnyObject));
-#else
             FormattersForAnyObject = new FormatterMapByType(typeof(HtmlFormatter<>), nameof(HtmlFormatter<object>.CreateTreeViewFormatterForAnyObject));
-#endif
         }
     }
 
-    // FIX: (HtmlFormatter.UseTreeView) delete this 
-    public static bool UseTreeView { get; set; }
-
     // FIX: (HtmlFormatter) this can return a formatter with the wrong MIME type
     public static ITypeFormatter GetPreferredFormatterFor(Type type) =>
         Formatter.GetPreferredFormatterFor(type, MimeType);
@@ -56,8 +49,6 @@ internal static void FormatAndStyleAsPlainText(
     {
         context.RequireDefaultStyles();
 
-        // FIX: (FormatAndStyleAsPlainText) can this be refactored out to a reusable instance?
-
         PocketView tag = div(pre(value.ToDisplayString(PlainTextFormatter.MimeType)));
         tag.HtmlAttributes["class"] = "dni-plaintext";
         tag.WriteTo(context);